Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

GCC defect fixes. #6833

Merged
merged 2 commits into from
Feb 26, 2019
Merged

GCC defect fixes. #6833

merged 2 commits into from
Feb 26, 2019

Conversation

jgiszczak
Copy link
Contributor

Change Description

This PR works around two gcc defects, one of which was fixed in gcc 7.1, the other of which was fixed in gcc 7.2. Supported platforms building with gcc will encounter the problems.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66297
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67274

Consensus Changes

N/A

API Changes

N/A

Documentation Additions

N/A

@spoonincode
Copy link
Contributor

It seems like an alternative fix to 67274 is to remove the auto. Is that a better stylistic approach?

@jgiszczak
Copy link
Contributor Author

It could obviate the need for a comment explaining the use of explicit this pointers but risks being 'streamlined' back to auto in some later commit. If the risk is deemed low enough, I can make that change.

@jgiszczak jgiszczak merged commit 035194c into develop Feb 26, 2019
@jgiszczak jgiszczak deleted the gcc-defect-fixes branch February 26, 2019 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants