Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Net plugin use local logger #6803

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Net plugin use local logger #6803

merged 3 commits into from
Feb 21, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Feb 21, 2019

Change Description

Co-Authored-By: Vincent Gu [email protected]

Consensus Changes

None

API Changes

None

Documentation Additions

Indicate that all net_plugin logging is controlled by "net_plugin_impl" in logging.json.

For example:

{
  "includes": [],
  "appenders": [{
      "name": "stderr",
      "type": "console",
      "args": {
        "format": "hello",
        "stream": "std_error",
        "level_colors": [{
            "level": "debug",
            "color": "green"
          },{
            "level": "warn",
            "color": "brown"
          },{
            "level": "error",
            "color": "red"
          }
        ]
      },
      "enabled": true
    },{
      "name": "stdout",
      "type": "console",
      "args": {
        "format": "hello",
        "stream": "std_out",
        "level_colors": [{
            "level": "debug",
            "color": "green"
          },{
            "level": "warn",
            "color": "brown"
          },{
            "level": "error",
            "color": "red"
          }
        ]
      },
      "enabled": true
    },{
      "name": "net",
      "type": "gelf",
      "args": {
        "endpoint": "10.0.0.1:12201",
        "host": "testnet_00"
      },
      "enabled": true
    }
  ],
  "loggers": [{
      "name": "default",
      "level": "debug",
      "enabled": true,
      "additivity": false,
      "appenders": [
        "stderr",
        "net"
      ]
    },{
      "name": "net_plugin_impl",
      "level": "debug",
      "enabled": true,
      "additivity": false,
      "appenders": [
        "stderr",
        "net"
      ]
    }
  ]
}

@larryk85 larryk85 self-requested a review February 21, 2019 19:58
Copy link
Contributor

@larryk85 larryk85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR, we should audit and group logging to better suit the information being presented. As in line 748, this should be an ilog and the same for 773. The inverse is true (should be wlog) for line 1507.

@heifner heifner merged commit 4cc0cad into develop Feb 21, 2019
@heifner heifner deleted the net-plugin-log branch February 21, 2019 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants