Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Use https url for wabt submodule #6589

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

coderobe
Copy link
Contributor

Change Description

A user agent that doesn't respect hsts could potentially be coerced into downloading malicious sources for wabt via a mitm attack. Prevent this by using a https upstream like the other submodules already do

Consensus Changes

n/a

API Changes

n/a

Documentation Additions

n/a

@spoonincode
Copy link
Contributor

This is good but I assume it only works for fresh clones? Even after checking out your branch, doing a submodule deinit+init+update, my submodule still seems to be using http. Do you know of a good & proper way to update this in place too?

@coderobe
Copy link
Contributor Author

You can probably change this in-place using git config, the config key on the submodule is url.

@spoonincode spoonincode changed the base branch from master to develop January 14, 2019 15:27
@spoonincode spoonincode changed the base branch from develop to master January 14, 2019 15:28
@spoonincode
Copy link
Contributor

@coderobe can you rebase this on develop please?

@heifner heifner changed the base branch from master to develop January 14, 2019 19:18
@heifner heifner changed the base branch from develop to master January 14, 2019 19:19
A user agent that doesn't respect hsts could potentially be coerced into downloading malicious sources for wabt via a mitm attack. Prevent this by using a https upstream like the other submodules already do
@coderobe coderobe changed the base branch from master to develop January 15, 2019 00:16
@coderobe
Copy link
Contributor Author

@spoonincode done

@spoonincode spoonincode merged commit a49f626 into EOSIO:develop Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants