This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Binary Releases #6003
Merged
Binary Releases #6003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
reviewed
Oct 15, 2018
| # make symlinks | ||
| #pushd ${PREFIX}/lib/cmake/${PROJECT} &> /dev/null | ||
| #ln -sf ../../../${SUBPREFIX}/lib/cmake/${PROJECT}/${PROJECT}-config.cmake ${PROJECT}-config.cmake | ||
| #ln -sf ../../../${SUBPREFIX}/lib/cmake/${PROJECT}/EosioTester.cmake EosioTester.cmake |
There was a problem hiding this comment.
All these commented out lines in this file. Is it supposed to be that way?
There was a problem hiding this comment.
Yeah, when we create full binary releases with libeosio and tester hopefully all that needs to be done in the generator scripts is uncomment these lines.
wanderingbort
approved these changes
Oct 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supplanting #5727, currently with this set up it will only create a package for [
cleos,keosd, andnodeos(if we think it is okay)]. Currently, I have this set up to install the binaries to /usr/opt/eosio/v1.x.x/bin and install symlinks to /usr/bin. I used this model foreosio.cdt's binary releases as it gives us clean versioning, but with a few simple modifications we can change this to install the binaries to /usr/bin. For this incarnation of the binary releases it doesn't make much difference in terms of versioning, but when we cleanup and fixEosioTesterto be included with a binary release, proper versioning becomes a very real issue, so I suggest the /usr/opt/eosio/v1.x.x approach. Or, /usr/share foreos, as everything should be native and not mostly wasm specific likeeosio.cdt.nodeos
Currently,
nodeoshas a dependence onCORE_SYMBOLthroughchain_plugin::get_account. This is only used if thecore symbolcannot be determined (norammarket), and is used to return the accounts liquid balance. I have not been able to come up with a reasonable solution to remove this dependence entirely, but the worst that happens is the query fails to find the accounts liquid balance and is displayed incleosas such.