This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
binary releases of cleos and keosd #5727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiszczak
suggested changes
Sep 20, 2018
| @@ -36,6 +36,10 @@ case "$1" in | |||
| adduser --no-create-home --group --system ${USER} | |||
| fi | |||
| set -e | |||
| touch /var/log/${PACKAGE} | |||
There was a problem hiding this comment.
All references to /var/log, /var/lib, and /etc should be eliminated. None of those directories are used by the software by default or explicitly by the documentation. Instead, that information is all kept in ~/.local/share/eosio. The old packages needed to install a genesis.json file, which is also no longer required.
With the elimination of installation to both /var and /etc, it's likely that usage of CMAKE_INSTALL_FULL_* is no longer required for any component.
There was a problem hiding this comment.
Not sure I follow what you expect.
message(WARNING ${CMAKE_INSTALL_FULL_BINDIR})
message(WARNING ${CMAKE_INSTALL_BINDIR})
This gives
CMake Warning at CMakeLists.txt:12 (message):
/usr/local/bin
CMake Warning at CMakeLists.txt:13 (message):
bin
ghost
suggested changes
Sep 26, 2018
To be determined |
Merged
|
Superseded by #6003 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note this will generate a dmg with cleos and keosd on Mac OSX, and a full install for DEB and RPM packages. Without changing all of the install cmake commands to disable during installation when using CPack generation, the work around is that it installs cleos and keosd to what CPack uses for it's default bin path (/usr/bin for both it seems) and everything else to /usr/local/eosio like normal. This at least doesn't expose the other binaries unless someone adds /usr/local/eosio to their path. sudo apt install and sudo apt remove eos.io work cleanly. And yum installs and uninstalls cleanly too.