This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
cleos remove wasm to wast conversion 📦 #10816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Also improve error reporting of wasm to wast errors.
spoonincode
reviewed
Oct 15, 2021
| @@ -6,6 +6,6 @@ namespace eosio { namespace chain { | |||
|
|
|||
| std::vector<uint8_t> wast_to_wasm( const std::string& wast ); | |||
| std::string wasm_to_wast( const std::vector<uint8_t>& wasm, bool strip_names ); | |||
| std::string wasm_to_wast( const uint8_t* data, uint64_t size, bool strip_names ); | |||
| std::string wasm_to_wast( const uint8_t* data, uint64_t size, bool strip_names, bool check_limits = true ); | |||
There was a problem hiding this comment.
can all the wasm_to_wast stuff be ripped out?
There was a problem hiding this comment.
Yes. It is not used, so might as well.
There was a problem hiding this comment.
it's probably possible to purge more, down in the libraries/wasm-jit/Source/WAST (and include dir). That would be highly desirable, but maybe not critical at the moment
There was a problem hiding this comment.
ah, hm, can't remove all too much in there since unit tests since use wast
heifner
changed the title
spoonincode
approved these changes
Oct 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
cleosto not perform wasm to wast conversion.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions