Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[docs]command ref docs fix - fix broken link, replace Set, fix callout #10362

Merged
merged 1 commit into from
May 17, 2021

Conversation

halsaphi
Copy link
Contributor

Change Description

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@halsaphi halsaphi requested a review from lparisc May 14, 2021 06:13
@halsaphi halsaphi changed the title command ref docs fix - fix broken link, replace Set, fix callout [docs]command ref docs fix - fix broken link, replace Set, fix callout May 14, 2021
@@ -42,7 +42,8 @@ The following information shows the different positionals and options you can us

## Requirements
* Install the currently supported version of `cleos`.
[[info | Note]] | `Cleos` is bundled with the EOSIO software. [Installing EOSIO](../../00_install/index.md) will also install the `cleos` and `keosd` comand line tools.
[[info | Note]]
| `Cleos` is bundled with the EOSIO software. [Installing EOSIO](../../../00_install/index.md) will also install the `cleos` and `keosd` comand line tools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleos is a program name. @bobgt Is it okay for system names (which we wrap in backticks as a convention) to use sentence case (as in Cleos) even when starting a sentence?

@@ -64,7 +65,7 @@ executed transaction: 4eb4cf3aea232d46e0e949bc273c3f0575be5bdba7b61851ab51d927cf
# eosio <= eosio::linkauth {"account":"bob","code":"scontract1","type":"hi","requirement":"customp1"}
```

2. permissions on a _bye_ action deployed to the _scontract1_ account so that the _bob_ account's `active` permission and _customp2_ permission are authorized:
2. Set permissions on a _bye_ action deployed to the _scontract1_ account so that the _bob_ account's `active` permission and _customp2_ permission are authorized:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why active and customp2 have to use different formatting styles. Both are permissions and they are both instantiated from the same class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to differentiate between defaut and custom permissions to emphsise this for this how to

@halsaphi halsaphi merged commit 2e42297 into develop May 17, 2021
@kj4ezj kj4ezj deleted the develop-how-to-link-perms branch July 19, 2021 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants