This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
flakiness fix for forked chain test #10356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjohnson5972
approved these changes
May 13, 2021
| @@ -417,19 +423,23 @@ def getBlock(self, blockNum): | |||
| if not prodChanged: | |||
| if preKillBlockProducer!=blockProducer0: | |||
| prodChanged=True | |||
| Print("prodChanged = True") | |||
There was a problem hiding this comment.
Are we keeping these print statements for diagnosing more failures over time?
There was a problem hiding this comment.
yes. it is hard to understand what is happening without those
|
Didn't fix the problem. https://buildkite.com/EOSIO/eosio-lrt/builds/4329 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes flakiness in
nodeos_forked_chain_lr_testFlakiness as caused by waitForBlock timeout that was default (60 seconds).
Sometimes it requires longer timeout because of producer schedule for 10 producers is 10 * (12 * 0.5) = 60.
So when wait starts simultaneously with wait for next producer schedule test fails because of error getting next block.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions