This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix db_modes_test pipeline fails, see epe889 #10237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n before call wait. As the trace information is very limit. detail see epe889, the buildkite fails are very possible wait an already terminated NODEOS_PID
|
pipiline |
jgiszczak
suggested changes
Apr 12, 2021
… go, in not, need stop and return the error code.
jgiszczak
approved these changes
Apr 13, 2021
12 tasks
This was referenced Jun 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Start 10237 description ......
EPE 889
In function
run_expect_success() {
run_nodeos "$@"
local NODEOS_PID=$!
sleep 10
kill $NODEOS_PID
wait $NODEOS_PID
}
wait throw exception, but kill not throw. The biggest possible is the timing of wait. if the kill finished rapidly before call wait, so the wait $NODEOS_PID is an already killed PID so wait it will throw. However the same fail didn't repro in my local PC. In my local Macbook, a case happened was that Nodes shutdown by it self. in this case, kill should throw instead of wait. Because kill didn't throw but wait throws, I think it is very possible Nodes was killed before wait call. in this case, don't let wait throw stop the test script.
End 10237 description ......
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions