This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Cleos print error message from server when parse json failed #10059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to easy understand what happened.
heifner
suggested changes
Feb 17, 2021
heifner
reviewed
Feb 17, 2021
…ot an error. remove the error notice line.
heifner
suggested changes
Feb 18, 2021
heifner
suggested changes
Feb 18, 2021
Copied from another one, forget to delete the doc section. now it's gone. |
heifner
approved these changes
Feb 18, 2021
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Start 10059 description ......
EPE 436
In some case, the server can't give Json string to caller, it give a html message to show the possible reason why the request failed. but the do_http_call function still try to parse the string as json string and throw an json parse error message(it is not unstandable), now just print the original string from server so easy to understand what happned.
However, do_http_call is trying to parse string which is supposed to be handled by higher layer function, that is not usual.
End 10059 description ......
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions