Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

./scripts/eosio_build.sh could make it more obvious which package is an issue #7563

Closed
matthewdarwin opened this issue Jun 29, 2019 · 0 comments
Assignees
Labels
build Issues related to building

Comments

@matthewdarwin
Copy link

When the build starts it looks like this:

====================== Starting EOSIO Dependency Install ===========================
Architecture: Linux
OS name: Ubuntu
OS Version: 18.04
CPU cores: 4
Physical Memory: 65G
Disk space total: 3602G
Disk space available: 3331G
[Ensuring installation of build-essential]
 - Package: build-essential found.
[Ensuring package dependencies]
 - git found!
 - make found!
 - bzip2 found!
 - automake found!
 - libbz2-dev found!
 - libssl-dev found!
 - doxygen found!
[etc]

If some dependency is not found it says "ff NOT found". Ok.... but looking through the list it's not immedialy obvious where the errors are because

  1. the list is dominated by the word "found" which is common to each line
  2. the 'ok' things have an exclamation point. Shouldn't the failures have the exclamation point?

I'm sure some wording could be changed to make it more obvious which one failed at a quick glance:

git ok
make NOT FOUND!
gzip2 ok

(ok maybe less shouting would be good).

Anyway, this is a minor issue... Just filing it because I noticed it.

@NorseGaud NorseGaud self-assigned this Jun 29, 2019
@arhag arhag added the build Issues related to building label Jun 29, 2019
NorseGaud added a commit that referenced this issue Jul 1, 2019
[1.8.x] Better found/not found messages for clarity
NorseGaud added a commit that referenced this issue Jul 1, 2019
[develop] Better found/not found messages for clarity
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issues related to building
Projects
None yet
Development

No branches or pull requests

3 participants