Reimplement chainbase using intrusive instead of multi_index #58

swatanabe-b1 · 2019-10-22T18:35:51Z

Primary Features:

Per container memory pools
full exception safety
lighter weight representation of the undo stack.
avl trees instead of rb trees.

…ail.

… temporaries.

…mprovement when loading snapshots.

arhag

Still need to finish reviewing undo_index.hpp.

CMakeLists.txt

include/chainbase/chainbase_node_allocator.hpp

include/chainbase/undo_index.hpp

include/chainbase/shared_cow_string.hpp

include/chainbase/undo_index.hpp

arhag

More reviewing left to do on undo_index.hpp. I just wanted to get the pending comments out earlier.

include/chainbase/undo_index.hpp

swatanabe-b1 added 30 commits October 2, 2019 10:14

Initial reimplementation of chainbase.

583b0f2

Fix indentation

13be5c9

Add members to undo_index as required by nodeos.

0358735

More updates

045f651

Make the value_type correct.

67a3387

Track down and fix the bug that was causing the nodeos unittests to f…

82ecb49

…ail.

Fix the tests and reduce rebalancing in modify.

c8d6aa2

Use a custom node_type, to avoid the overhead of using offset_ptr for…

4969f60

… temporaries.

Use node_allocator.

9c85067

Add tests and fix memory leak.

0df2648

Fix memory leak

ae0b82f

Switch to AVL tree.

00b7958

Put the undo stack in a separate pool from the main container.

7a94865

Use separate node pools for each container.

83a78d9

Use node_allocator in chainbase_tests.

21e30be

Implement cow for shared_blob

865dfea

An id can never be added again after it is removed.

605368f

Reduce binary trees in the undo stack.

dc95d88

Prune some dead code

57350d6

avl_set seems to be slightly faster, and makes a fairly significant i…

5967854

…mprovement when loading snapshots.

Use optimized insertion functions.

eaa42dc

Use avltree and temporarily allow non-unique elements in undo.

445df32

Fix regular replay with replay opts.

c26f2d5

Fix issues from valgrind

9015362

Mostly eliminate new_ids.

514cc77

Simplify tracking of mtime/erased items

39fac1d

Move deduplication from squash to undo.

2979834

constant time squash.

b45b09b

Make undo_index fully exception safe.

16d978e

Cleanup dead code.

28a6730

arhag suggested changes Oct 28, 2019

View reviewed changes

swatanabe-b1 added 8 commits October 29, 2019 09:33

Delete copy operations of scope_exit

94daf5d

Add missing dec_refcount.

9d6a5c4

Use std::allocator_traits.

565513f

Verify size and alignment of list item.

e560f50

Update C++ version.

f1885f3

chainbase::undo_state is dead.

77897d5

Rename template parameters to be more clear.

41ad213

Fix project for end iterators.

03b61ca

arhag suggested changes Oct 29, 2019

View reviewed changes

swatanabe-b1 added 10 commits October 29, 2019 16:08

Remove unused overload of find.

1cbcb36

Add int overload of project.

c11992f

More renaming.

541f8ef

Remove unnecessary scope_exit.

bcfaabc

Avoid memcpy/memset when it's just going to be overwritten later.

258c6f2

Remove c_str. We should never be depending on null-termination.

37b54ce

Verify requirements on indices.

dcea84e

Require ordered_unique only

6fc3c7b

Fix memory leak.

42c5cfd

Avoid dereferencing end iterators.

ab29a23

arhag suggested changes Nov 1, 2019

View reviewed changes

swatanabe-b1 added 5 commits November 1, 2019 15:24

Renaming for consistency

568328a

Forwarding.

3ea72d9

Handle committing nothing.

874b8e3

Check that the id does not change.

6524d21

shared_vector is unused.

5471547

arhag approved these changes Nov 5, 2019

View reviewed changes

heifner approved these changes Nov 5, 2019

View reviewed changes

swatanabe-b1 merged commit 100f76d into master Nov 5, 2019

swatanabe-b1 deleted the undo_index branch November 5, 2019 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reimplement chainbase using intrusive instead of multi_index #58

Reimplement chainbase using intrusive instead of multi_index #58

swatanabe-b1 commented Oct 22, 2019

arhag left a comment

arhag left a comment

Reimplement chainbase using intrusive instead of multi_index #58

Reimplement chainbase using intrusive instead of multi_index #58

Conversation

swatanabe-b1 commented Oct 22, 2019

arhag left a comment

Choose a reason for hiding this comment

arhag left a comment

Choose a reason for hiding this comment