Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On refreshing the page, selected icon getting cached in search result. #16

Open
cyntss opened this issue Oct 14, 2021 · 5 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@cyntss
Copy link
Member

cyntss commented Oct 14, 2021

Importing issues from old repo on Gitlab.
Created by: @m1-key


If you select an icon and then refresh the page, the selected icon automatically gets cached. And by default, it searches for similar icons of the selected one, and the same goes for the multiple selected, in this the last selected icon get cached in the search result, and then on refreshing the page it automatically searches according to the last selected icon.
So the gist is that if a user refreshes the page and before refreshing he/she has selected any icon then after refresh it searches for icons similar to the selected one. I have attached a video for the same.

simplescreenrecorder-2021-02-18_00.22.58.mp4
@cyntss
Copy link
Member Author

cyntss commented Oct 14, 2021

We discussed this on Slack and we agreed that we will do the following:

  • When an icon is selected, the URL changes, which is expected. This is so that someone can share a link to an icon. This will not change.
  • When an icon is selected and the URL is either accessed from another browser (shared) or the same screen is refreshed, instead of filtering the icon, we will select it. (highlight it) and position the window on the Y axis to make the icon visible.

@ayushsatyam146
Copy link
Contributor

I would like to work on this issue. Can I work on this @cyntss?

@cyntss
Copy link
Member Author

cyntss commented Jan 25, 2022

@ayushsatyam146 yes of course! be very mindful of testing all different scenarios: when a user wants to share an icon, when a user receives the URL of a shared icon, try it with icons in the top of the list as well as icons at the bottom of the list to make sure that the selection is visible.

@ayushsatyam146
Copy link
Contributor

Added PR #22 for this issue. Please review.

@ayushsatyam146
Copy link
Contributor

I think this issue can be closed now. I have tackled this issue in PR #126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants