Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement colorblind mode #83

Merged
merged 3 commits into from
Nov 26, 2024
Merged

implement colorblind mode #83

merged 3 commits into from
Nov 26, 2024

Conversation

cooperq
Copy link
Collaborator

@cooperq cooperq commented Nov 25, 2024

Closes #77

Copy link
Collaborator

@wgreenberg wgreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one comment, though i do worry about calling it colorblind_mode when it only addresses a single colorblindness type. probably fine for now, but as we get more users, we'll probably wanna work on this more.

bin/src/daemon.rs Show resolved Hide resolved
@cooperq
Copy link
Collaborator Author

cooperq commented Nov 26, 2024

just the one comment, though i do worry about calling it colorblind_mode when it only addresses a single colorblindness type. probably fine for now, but as we get more users, we'll probably wanna work on this more.

looking at simulations I think just switching green to blue should be about enough to differentiate the color change for most types of color blindness. The more obvious thing might be something like a dashed line I guess but I worry about that being noticed by someone inspecting the device.

Copy link
Collaborator

@wgreenberg wgreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wgreenberg wgreenberg merged commit 95e8f84 into main Nov 26, 2024
1 check passed
@wgreenberg wgreenberg deleted the colorblind branch November 26, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorblind mode
2 participants