Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Insufficient test coverage error not triggered by wildcard target and no tests #7272

Closed
jeremyn opened this issue Oct 3, 2016 · 2 comments
Closed

Comments

@jeremyn
Copy link
Contributor

jeremyn commented Oct 3, 2016

The below ruleset, from pull request #7248 , has a target with a lefthand wildcard and no tests, so it should trigger the Ruleset test coverage was insufficient. error. However it doesn't trigger that error in Travis or when I run fetch-test.sh against it.

<ruleset name="Vimeo Pro.com">
    <target host="vimeopro.com" />
    <target host="www.vimeopro.com" />
    <target host="*.vimeocdn.com" />

    <rule from="^http:" to="https:" />
</ruleset>
@cschanaj
Copy link
Collaborator

#11998

@jeremyn
Copy link
Contributor Author

jeremyn commented Oct 22, 2017

This is fixed now, thanks @cschanaj .

@jeremyn jeremyn closed this as completed Oct 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants