Unnecessary overlapping targets in rulesets #12322
Comments
|
Updated to group output, it's less noisy this way. |
|
Not sure if I should attempt to remove these automatically or going manually one by one will be easier... |
|
For some of them, conceptually, it kind of makes sense to be that way. For example, What I like about it is that the day custom subdomains support is removed, we are just one line away to fix this ruleset, we don't have to find and check every "regular" subdomain again. A similar alternative would be: <target host="userecho.com"/>
<target host="*.userecho.com"/>
<!-- All regular subdomains -->
<test url="http://www.userecho.com/"/>
<test url="http://blog.userecho.com/"/>
<test url="http://feedback.userecho.com/"/>
<!-- Customer subdomains examples -->
<test url="http://imgur.userecho.com/"/>
<test url="http://unchecky.userecho.com/"/>But I have no idea how big an impact this overlapping targets have on performance. |
|
That's interesting, looking at cdc90c4, it looks like most of the overlaps are due to the fact that the ruleset author didn't account for the fact that left wildcards affect more than first-level subdomains. |
|
Well, I noticed them as part of hunt for wildcard-in-the-middle regexps, and thought that it makes sense to remove overlaps completely as they're somewhat confusing. On the other hand, I see your point too, even though 1) But I know not everyone in HTTPS Everywhere team agrees with this 😄 Anyway, in cases where they overlap, I think using |
Yup, I got the same impression. |
AFAIK, the lookup performance will be improved as the complicated operations in
I do not know this until recently when I create #11998 looking at rules.js. Maybe we should document this behavior. |
|
It is documented at https://www.eff.org/https-everywhere/rulesets like some other details, but yes, looks like that information is out of sync with contributing guidelines in the repo. |
|
Automated fix was merged, so closing this as resolved. |
#12320 helped to find a list of rulesets where targets overlap, and so unnecessarily duplicate each other. Reducing number of those might help with #12232:
*.16163.comalso coverswww.16163.com,app.16163.com,bbs.16163.com,m.16163.com*.3min.dealso coverswww.3min.de*.acenet-inc.netalso covers*.esupport.acenet-inc.net*.ace.advertising.comalso coverssecure.ace.advertising.com*.afrinic.netalso covers*.meeting.afrinic.net*.airtricity.comalso coverswww.airtricity.com*.alice-dsl.dealso coverswww.alice-dsl.de*.american.edualso covers*.wcl.american.edu*.asmp.orgalso coverswww.admin.asmp.org*.anl.govalso coverswww.*.anl.gov*.argos.co.ukalso coversimage.email.argos.co.uk*.audiko.netalso coverscss.cdn.audiko.net,jpg.st.audiko.net*.uni-weimar.dealso covers*.webmail.uni-weimar.de*.bennetts.co.ukalso covers*.quotes.bennetts.co.uk*.brenet.dealso covers*.webmail.brenet.de*.caller.comalso coverswww.caller.com,login.caller.com*.cfda.govalso covers*.www.cfda.gov*.champssports.comalso covers*.e.champssports.com,*.www.champssports.com*.city.ac.ukalso coverswww.soi.city.ac.uk,*.www.city.ac.uk*.clara.netalso coverswebmail.bln.de.clara.net,nswebmail.uk.clara.net,portal.uk.clara.net*.cloudhexa.comalso covers*.www.cloudhexa.com*.hr.columbia.edualso covers*.managers.hr.columbia.edu*.compendiumblog.comalso coverscdn2.content.compendiumblog.com,cdn.content.compendiumblog.com,global.content.compendiumblog.com*.cfr.orgalso coverssecure.www.cfr.org*.cox.comalso covers*.store.cox.com*.cox.netalso coversidm.east.cox.net*.adage.comalso coverswww.amiga.adage.com*.dailymotion.comalso coversak2.static.dailymotion.com*.digia.comalso coversblog.qt.digia.com*.img-dpreview.comalso covers*.static.img-dpreview.com*.insightmgr.comalso covers*.digi.insightmgr.com,*.www.insightmgr.com*.dotcomhost.comalso covers*.webmail.dotcomhost.com*.dpfile.comalso coversqcloud.dpfile.com,www.dpfile.com*.eastbay.comalso covers*.teamsales.eastbay.com,*.www.eastbay.com*.epi.orgalso covers*.secure.epi.org*.thesims3.comalso covers*.store.thesims3.com*.epson.comalso coversglobal.latin.epson.com*.eyeviewads.comalso coverstrack.eyeviewads.com*.familie-redlich.dealso coverswww.systeme.familie-redlich.de*.fbo.govalso covers*.www.fbo.gov*.filmthreat.comalso covers*.www.filmthreat.com*.final-score.comalso covers*.e.final-score.com,*.www.final-score.com*.footaction.comalso covers*.www.footaction.com*.freelancer.comalso covers*.www.freelancer.com*.freelancer.co.ukalso covers*.www.freelancer.co.uk*.fwmrm.netalso covers2912a.v.fwmrm.net*.futurequest.netalso coverswww.service.futurequest.net*.gaiaonline.comalso covers*.cdn.gaiaonline.com*.gsn.comalso coverswww.tv.gsn.com*.garmin.comalso coverswww.garmin.com*.gigaserver.czalso covers*.www.gigaserver.cz*.gizmodo.comalso covers20khz.gizmodo.com,es.gizmodo.com,factually.gizmodo.com,fieldguide.gizmodo.com,homeofthefuture.gizmodo.com,indefinitelywild.gizmodo.com,io9.gizmodo.com,lego.gizmodo.com,offworld.gizmodo.com,paleofuture.gizmodo.com,reframe.gizmodo.com,space.gizmodo.com,sploid.gizmodo.com,throb.gizmodo.com,toyland.gizmodo.com,us.gizmodo.com,www.gizmodo.com,cache.gizmodo.comgoogle.*also coversgoogle.comimages.google.*also coversimages.google.com*.googleusercontent.comalso covers*.corp.googleusercontent.comgoogle.*also coversgoogle.com*.gostats.comalso coverswww.ssl.gostats.com*.griffith.edu.aualso covers*.secure.griffith.edu.au*.hitbtc.comalso coversaffiliate.hitbtc.com,auth.hitbtc.com,blog.hitbtc.com,demo.hitbtc.com,forum.hitbtc.com,www.hitbtc.com*.home.plalso covers*.akcje.home.pl,*.panel.home.pl,*.poczta.home.pl,*.m.poczta.home.pl*.poczta.home.plalso covers*.m.poczta.home.pl*.honest.comalso coversblog.honest.com,img.honest.com,www.honest.com*.hotpics-amateur.comalso coverswww.collection.hotpics-amateur.com*.imageshack.usalso coverswww.imageshack.us,imagizer.imageshack.us,post.imageshack.us,a.imageshack.us*.bkb.chalso coversintegration.quotes.bkb.ch*.kidsfootlocker.comalso covers*.www.kidsfootlocker.com*.kixeye.comalso covers*.cdn.kixeye.com*.ladyfootlocker.comalso covers*.www.ladyfootlocker.com*.lastpass.comalso coverswww.lastpass.com,0.lastpass.com,account.lastpass.com,accounts.lastpass.com,blog.lastpass.com,download.lastpass.com,enterprise.lastpass.com,forums.lastpass.com,helpdesk.lastpass.com,localvault.lastpass.com,m.lastpass.com,manda.lastpass.com,pollserver.lastpass.com,portable.lastpass.com,rodan.lastpass.com,service.lastpass.com,teams.lastpass.com,uber.lastpass.com,vaul.lastpass.com*.linuxnewmedia.comalso covers*.shop.linuxnewmedia.com*.linuxnewmedia.dealso covers*.shop.linuxnewmedia.de*.liquidweb.comalso coversmedia.cdn.liquidweb.com*.london2012.comalso coverswww.festival.london2012.com,tickets.london2012.com,www.tickets.london2012.com*.loopia.sealso covers*.www.loopia.se*.lumosity.comalso coversstatic.sl.lumosity.com*.foto.mail.rualso coversavt.foto.mail.ru,content.foto.mail.ru*.my.mail.rualso coverscontent.foto.my.mail.ru,stat.my.mail.ru,videoapi.my.mail.ru*.maricopa.edualso covers*.sis.maricopa.edu*.maxymiser.comalso covers*.www.maxymiser.com*.mediafire.comalso coversstaticcdn.mediafire.com,www.mediafire.com,www1.mediafire.com,www2.mediafire.com,cdn.mediafire.com,cdnssl.mediafire.com,m.mediafire.com*.meituan.comalso coverswww.meituan.com,analytics.meituan.com,b.meituan.com,daili.meituan.com,hotel.meituan.com,mos.meituan.com,p0.meituan.com,p1.meituan.com,passport.meituan.com,report.meituan.com,s0.meituan.com,s1.meituan.com,waimaie.meituan.com,i.meituan.com,waimai.meituan.com,kaidian.waimai.meituan.com*.mentor.comalso covers*.store1.mentor.com*.micgadget.comalso covers*.store.micgadget.com*.msnbc.msn.comalso covers*.today.msnbc.msn.com*.mytalkdesk.comalso coverswww.mytalkdesk.com*.nature.nps.govalso coversscience.nature.nps.gov*.navteq.comalso coverscss.mapreporter.navteq.com*.itespresso.fralso coversquiz.itespresso.fr*.oberlin.edualso covers*.cs.oberlin.edu,oncampus.csr.oberlin.edu*.onesite.comalso covers*.admin.onesite.com*.onsugar.comalso coverssecure.*.onsugar.com,www.*.onsugar.com*.pair.comalso covers*.webmail.pair.com*.upc.edualso covers*.blog.upc.edu*.poppysports.comalso covers*.www.poppysports.com*.prxy.comalso coverswww.prxy.com*.ru.nlalso covers*.cmbi.ru.nl,*.hosting.ru.nl,*.portalhelp.hosting.ru.nl*.hosting.ru.nlalso covers*.portalhelp.hosting.ru.nl*.royalmail.comalso covers*.shop.royalmail.com*.rtems.orgalso coversdevel.rtems.org,docs.rtems.org,git.rtems.org,lists.rtems.org,wiki.rtems.org,www.rtems.org*.secunet.comalso coverswww.secunet.com*.superforum.orgalso covers*.dating.superforum.org*.sxnarod.comalso coverswap.dating.sxnarod.com*.sheetmusicplus.comalso coversssl.assets.sheetmusicplus.com*.skrill.comalso coversaccount.skrill.com,help.skrill.com,sso.skrill.com,www.skrill.com*.snagajob.comalso coverswww.snagajob.com*.spoki.lvalso covers*.www.spoki.lv*.stumbleupon.comalso covers*.b9.stumbleupon.com*.symanteccloud.comalso coversbuy.symanteccloud.com,static.symanteccloud.com,static1.symanteccloud.com,static2.symanteccloud.com,static3.symanteccloud.com*.ad-srv.netalso covers*.ad.ad-srv.net*.o2.czalso covers*.www.o2.cz*.textbooks.comalso covers*.www.textbooks.com*.escapistexpo.comalso coverswww.sec.escapistexpo.com*.ubs.comalso covers*.ibb.ubs.com*.ucsd.edualso coversa4.ucsd.edu,acs-webmail.ucsd.edu,altng.ucsd.edu,aventeur.ucsd.edu,cinfo.ucsd.edu,facilities.ucsd.edu,gradapply.ucsd.edu,graduateapp.ucsd.edu,jacobsstudent.ucsd.edu,myucsdchart.ucsd.edu,sdacs.ucsd.edu,shs.ucsd.edu,ted.ucsd.edu,ucsdbkst.ucsd.edu,a.ucsd.edu,acms.ucsd.edu,bookstore.ucsd.edu,www.bookstore.ucsd.edu,cs.ucsd.edu,www.cs.ucsd.edu,cse.ucsd.edu,www.cse.ucsd.edu,ece.ucsd.edu,www.ece.ucsd.edu,hdh.ucsd.edu,www.hdh.ucsd.edu,hds.ucsd.edu,www.hds.ucsd.edu,maeweb.ucsd.edu,nanoengineering.ucsd.edu,www.nanoengineering.ucsd.edu,ne-web.ucsd.edu,ne.ucsd.edu,neweb.ucsd.edu,roger.ucsd.edu,se.ucsd.edu,structures.ucsd.edu,www.structures.ucsd.edu,uxt.ucsd.edu,www-cs.ucsd.edu,www-cse.ucsd.edu,www-ne.ucsd.edu,www-structures.ucsd.edu,act.ucsd.edu,health.ucsd.edu,libraries.ucsd.edu,studenthealth.ucsd.edu,www-act.ucsd.edu,accesslink.ucsd.edu,acs.ucsd.edu,cri.ucsd.edu,desktop.ucsd.edu,financiallink.ucsd.edu,iwdc.ucsd.edu,marketplace.ucsd.edu,mytritonlink.ucsd.edu,www.mytritonlink.ucsd.edu,resnet.ucsd.edu,software.ucsd.edu,sysstaff.ucsd.edu,tritonlink.ucsd.edu,www.tritonlink.ucsd.edu,uclearning.ucsd.edu,webmail.ucsd.edu,www-acs.ucsd.edu*.doe.govalso coverswww.*.doe.gov*.universalsubtitles.orgalso coverss3.www.universalsubtitles.org*.alaska.edualso coverswww.*.alaska.edu,biotech.inbre.alaska.edu,lib.uaa.alaska.edu,*.vpn.alaska.edu*.unibe.chalso coverswww.*.unibe.ch*.udel.edualso covers*.facilities.udel.edu,*.nss.udel.edu*.rug.nlalso coverswww.astro.rug.nl*.uidaho.edualso coverswww.*.uidaho.edu,www2.sites.uidaho.edu*.umass.edualso covers*.oit.umass.edu,*.spire.umass.edu,*.umii.umass.edu*.usf.edualso covers*.stpete.usf.edu*.soton.ac.ukalso coverswww.*.soton.ac.uk*.uh.edualso coverswww.*.uh.edu,fp.my.uh.edu,*.nsm.uh.edu*.umaine.edualso coverswww.*.umaine.edu*.salford.ac.ukalso covers*.www.salford.ac.uk*.waikato.ac.nzalso coverstools.its.waikato.ac.nz,www.mngt.waikato.ac.nz*.wisc.edualso covers*.library.wisc.edu*.uptodown.comalso coverswww.uptodown.com,api.uptodown.com,blog.uptodown.com,dw.uptodown.com,feeds.uptodown.com,gstatic.uptodown.com,img.uptodown.com,stat.uptodown.com,stc.uptodown.com*.vaforvets.va.govalso coverswww.*.vaforvets.va.gov*.vba.va.govalso coverswww.*.vba.va.gov*.history.state.govalso coverswww.history.state.gov*.userecho.comalso coverswww.userecho.com,blog.userecho.com,feedback.userecho.com*.vdopia.comalso coversmobile.sb.vdopia.com*.wdfiles.comalso covers1.*.wdfiles.com,2.*.wdfiles.com,3.*.wdfiles.com,4.*.wdfiles.com,5.*.wdfiles.com,6.*.wdfiles.com,7.*.wdfiles.com,8.*.wdfiles.com,9.*.wdfiles.com*.wikinvest.comalso covers*.www.wikinvest.com*.wiley.comalso coversonlinelibrarystatic.wiley.com,sp.onlinelibrary.wiley.com*.wolframalpha.comalso coversapi.wolframalpha.com,api-cn.wolframalpha.com,api-maps.wolframalpha.com,api-tw.wolframalpha.com,developer.wolframalpha.com,m.wolframalpha.com,preview.wolframalpha.com,products.wolframalpha.com,volunteer.wolframalpha.com,wc.wolframalpha.com,www1.wolframalpha.com,www3.wolframalpha.com,www4b.wolframalpha.com,www4c.wolframalpha.com,www4d.wolframalpha.com,www4f.wolframalpha.com,www5a.wolframalpha.com,www5b.wolframalpha.com*.woot.comalso coversimages.deals.woot.com,gzip.static.woot.comcc @Hainish @cschanaj @koops76 @Bisaloo
The text was updated successfully, but these errors were encountered: