Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Use ESLint #10845

Closed
ghost opened this issue Jul 1, 2017 · 11 comments
Closed

Use ESLint #10845

ghost opened this issue Jul 1, 2017 · 11 comments

Comments

@ghost
Copy link

ghost commented Jul 1, 2017

We may use standard for rules.

@J0WI
Copy link
Contributor

J0WI commented Jul 5, 2017

See #8843 and #9347

@ghost
Copy link
Author

ghost commented Jul 5, 2017

@J0WI I suggested https://github.com/standard/standard instead of a homebrewn .eslintrc.yml file. This pull request is also out of date ("This branch has conflicts that must be resolved").

@jeremyn jeremyn mentioned this issue Jul 6, 2017
@jeremyn
Copy link
Contributor

jeremyn commented Jul 6, 2017

Despite the name, standardjs is not an official standard, it's just popular with some developers. It also has some unusual requirements like not allowing semicolons. Related Hacker News discussion: https://news.ycombinator.com/item?id=14045617.

Two other popular eslint configurations are from Google and Airbnb. Probably the ideal way of deciding what to use it to try all three of them and figure out which configuration most closely matches what we already have.

@ghost
Copy link
Author

ghost commented Jul 6, 2017

@ghost
Copy link
Author

ghost commented Jul 6, 2017

#10897

@Hainish
Copy link
Member

Hainish commented Jul 7, 2017

Can this be closed with the #10852 merge?

@ghost
Copy link
Author

ghost commented Jul 7, 2017

@Hainish No, it should be closed when one of the JS style guide PRs will be merged.

@ghost
Copy link
Author

ghost commented Jul 7, 2017

@Hainish Like #10909.

@ghost
Copy link
Author

ghost commented Jul 8, 2017

@Hainish I already created the PRs for each code style. Let's discuss which to use. Personally, I would prefer either Standard or Google.

@ghost
Copy link
Author

ghost commented Jul 8, 2017

I hope we'll finish this before the next release (#10888.)

@Bisaloo
Copy link
Collaborator

Bisaloo commented Jul 9, 2017

Should help with #4039.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants