Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Delete rulesets which are all gone from DNS #10595

Closed
cschanaj opened this issue Jun 23, 2017 · 6 comments
Closed

Delete rulesets which are all gone from DNS #10595

cschanaj opened this issue Jun 23, 2017 · 6 comments

Comments

@cschanaj
Copy link
Collaborator

cschanaj commented Jun 23, 2017

I suspected a number of rulesets having all target gone from DNS: #10516 (comment)

Please refer to gone-from-dns-list.txt

@Bisaloo
Copy link
Collaborator

Bisaloo commented Jun 27, 2017

@cschanaj, any idea why your script didn't pick up #10738, #10732, #10729?

@cschanaj
Copy link
Collaborator Author

cschanaj commented Jun 27, 2017

@Bisaloo For #10738, #10732 The items from the list only include ruleset which

  • Disabled by https-everywhere-checker once only
  • Number of occurrence of Could not resolve host: == number of non-wildcard target

The command I use can be modified to match rules failed the fetch test twice and Could not resolve host: == 2 * number of non-wildcard target, but I am afraid that the number of false results is going to be much more significant.

As for #10729, I guess it is because of the improper indentation (with space)

@cschanaj
Copy link
Collaborator Author

Let's wait for the discussion in #10516 (comment) complete before submitting new deletion PRs.

@jeremyn
Copy link
Contributor

jeremyn commented Dec 14, 2017

@cschanaj I merged your recent deletion PRs but from #10516 (comment) it sounds like full-fetch-test should get rid of these rulesets automatically, so you don't need to submit PRs to delete them. What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants