Collect addional info in mixin #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2024 22:26
smoors
reviewed
Nov 17, 2024
eessi/testsuite/eessi_mixin.py
Outdated
Comment on lines
205
to
211
| try: | ||
| software_subdir = sn.extractsingle(r'EESSI_SOFTWARE_SUBDIR: (?P<subdir>.*)$', | ||
| f'{self.stagedir}/{self.stdout}', 'subdir', str) | ||
| if software_subdir: | ||
| self.cvmfs_software_subdir = f'{software_subdir}' | ||
| except SanityError: | ||
| pass |
eessi/testsuite/eessi_mixin.py
Outdated
Comment on lines
213
to
220
| try: | ||
| module_path = sn.extractsingle(r'FULL_MODULEPATH: (?P<modpath>.*)$', f'{self.stagedir}/{self.stdout}', | ||
| 'modpath', str) | ||
| print(f"Full modulepath: {module_path}") | ||
| if module_path: | ||
| self.full_modulepath = f'{module_path}' | ||
| except SanityError: | ||
| pass |
Co-authored-by: Sam Moors <[email protected]>
…test-suite into collect_addional_info_in_mixin
…. This way, we don't need the try block.
|
one test fails, and the check hangs.
@casparvl any idea why this happens? EDIT: problem is dry-run, see suggestion below (i took the liberty to commit it directly into your PR) |
smoors
reviewed
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #196
Note that the nodenames on which the test is run are already logged by the ReFrame framework, so we don't need to do that.
Discussed on the ReFrame slack channel. The challenge is that we want the variables from the batch nodes, so it has to be printed with
postrun_cmds. But then, we need to get it from the output, and into a ReFramevariableso that it is logged. Those need to be initialized in the class body. Then can be updated with the output of the extracted information. We use sanity functions to extract from the output, catching the SanityError that is produced if there is no match (as we don't want the test to fail because of this). Note that SanityError's are actually expected for runs on local software stack, since then theEESSI_*environment variables are not set, and the pattern match fails. That's fine, we just want the variables to read'None'in those cases.