set SRUN_CPUS_PER_TASK for srun launcher #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoors
changed the title
casparvl
approved these changes
May 13, 2024
There was a problem hiding this comment.
Lgtm! Setting the environment variable doesn't hurt: SLURM versions outside of the discussed range (>= 22.05 < 23.11) just ignore it, while it solves the issue that the number of CPUS per task is not propagated to the SRUN command for that particular range of SLURM versions.
Ran reframe -c test-suite/eessi/testsuite/tests/apps/tensorflow/tensorflow.py --run on Karolina, this completed just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also discussion in #139