Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify test names: EESSI_ + software name (with '-' replaced by '_') + optional label for type of test #108

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

boegel
Copy link
Contributor

@boegel boegel commented Feb 1, 2024

As far as I can tell, there's no way to tweak the test name, it's always determined by the Python class name (see https://reframe-hpc.readthedocs.io/en/stable/manpage.html#test-naming-scheme)

Before these changes (with EESSI pilot 2021.12 as available modules):

$ reframe --list --system hortense:cpu_rome_256gb --tag CI --tag 2_cores
...
[List of matched checks]
- GROMACS_EESSI %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=2_cores %module_name=GROMACS/2020.4-foss-2020a-Python-3.8.2 /1d77cf1a
- GROMACS_EESSI %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=2_cores %module_name=GROMACS/2020.1-foss-2020a-Python-3.8.2 /9857398f
- osu_coll %benchmark_info=mpi.collective.osu_allreduce %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /82cca1df
- osu_coll %benchmark_info=mpi.collective.osu_allreduce %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /180c80da
- osu_coll %benchmark_info=mpi.collective.osu_alltoall %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /890c65c1
- osu_coll %benchmark_info=mpi.collective.osu_alltoall %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /62da5e4a
- osu_pt_2_pt %benchmark_info=mpi.pt2pt.osu_latency %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /691d7eb9
- osu_pt_2_pt %benchmark_info=mpi.pt2pt.osu_latency %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /a714d15e
- osu_pt_2_pt %benchmark_info=mpi.pt2pt.osu_bw %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /a1999431
- osu_pt_2_pt %benchmark_info=mpi.pt2pt.osu_bw %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /80b32ca6
- TENSORFLOW_EESSI %scale=2_cores %module_name=TensorFlow/2.3.1-foss-2020a-Python-3.8.2 %device_type=cpu /7b478c18
Found 11 check(s)

With these changes:

$ reframe --list --system hortense:cpu_rome_256gb --tag CI --tag 2_cores
...
[List of matched checks]
- EESSI_GROMACS %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=2_cores %module_name=GROMACS/2020.4-foss-2020a-Python-3.8.2 /609972e8
- EESSI_GROMACS %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=2_cores %module_name=GROMACS/2020.1-foss-2020a-Python-3.8.2 /4c5c9c39
- EESSI_OSU_Micro_Benchmarks_coll %benchmark_info=mpi.collective.osu_allreduce %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /b0ba2f19
- EESSI_OSU_Micro_Benchmarks_coll %benchmark_info=mpi.collective.osu_allreduce %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /5b97a275
- EESSI_OSU_Micro_Benchmarks_coll %benchmark_info=mpi.collective.osu_alltoall %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /0eb2c6b1
- EESSI_OSU_Micro_Benchmarks_coll %benchmark_info=mpi.collective.osu_alltoall %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /aa437fd4
- EESSI_OSU_Micro_Benchmarks_pt2pt %benchmark_info=mpi.pt2pt.osu_latency %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /e39fe386
- EESSI_OSU_Micro_Benchmarks_pt2pt %benchmark_info=mpi.pt2pt.osu_latency %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /5d5bb92f
- EESSI_OSU_Micro_Benchmarks_pt2pt %benchmark_info=mpi.pt2pt.osu_bw %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.7.1-gompi-2021a %device_type=cpu /197f6650
- EESSI_OSU_Micro_Benchmarks_pt2pt %benchmark_info=mpi.pt2pt.osu_bw %scale=2_cores %module_name=OSU-Micro-Benchmarks/5.6.3-gompi-2020a %device_type=cpu /98f3df8a
- EESSI_TensorFlow %scale=2_cores %module_name=TensorFlow/2.3.1-foss-2020a-Python-3.8.2 %device_type=cpu /a640020c
Found 11 check(s)

…ced by '_') + optional label for type of test
@boegel boegel changed the title unify test names: EESSI_ + software name (with '-' replaced by '_') + optional label for type of test unify test names: EESSI_ + software name (with '-' replaced by '_') + optional label for type of test Feb 1, 2024
Copy link
Collaborator

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors merged commit 937e34e into EESSI:main Feb 1, 2024
9 checks passed
@boegel boegel deleted the test_naming branch February 1, 2024 15:46
@laraPPr laraPPr added this to the 0.2.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants