Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra memory request silently fails if resource is not set in config #181

Closed
casparvl opened this issue Sep 17, 2024 · 2 comments · Fixed by #182
Closed

Extra memory request silently fails if resource is not set in config #181

casparvl opened this issue Sep 17, 2024 · 2 comments · Fixed by #182

Comments

@casparvl
Copy link
Collaborator

On azure_mc, the ESPResSo test was failing with an OOM error. I checked, and the test does call the hook that requests memory here. This then calls this hook
which essentially sets:

test.extra_resources = {'memory': {'size': f'{req_mem_per_node}M'}}

Surprisingly, that field seems to be completely ignored if the config doesn't contain a section like

    'resources': [
        {
            'name': 'memory',
            'options': ['--mem={size}'],
        }
    ],

I'm not sure if we can query the existence of that config item explicitly, or what the documented behavior is for requesting a resource that isn't specified. If the documented behavior is a silent pass, we should try to hard-code a check and throw an error ourselves if this resource isn't set.

@casparvl
Copy link
Collaborator Author

Ok, this is documented behavior:

If the resource name specified in this variable does not match a resource name in the partition configuration, it will be simply ignored.

@casparvl
Copy link
Collaborator Author

We should be able to check current_partition.resources for a resource named memory and print an associated error (or maybe better: a warning) if we don't find it. Warning should say something that no resources item with the name memory was found in the config file and that this may result in OOM errors, and that it is highly advised to specify how memory (per node) should be requested for the given batch scheduler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant