-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling issues with tkinter 8.6.14 #2235
Comments
Opened this issue over at the tcl/tk repo: https://core.tcl-lang.org/tk/tktview/8162e9b7a90465f0b2a761c9515dfbc45d4b7e9f |
For what it's worth, this doesn't happen on my machine, and I'm not using any scaling. I can test on my laptop that does have 200% scaling, but it sounds like that might be the cause. |
Given this is likely an upstream issue with TCL/TK, marking as such. Will monitor until TCL/TK either kicks it back or fixes it. |
Did you test this build? Would be great if you could test it on another device 🙂 |
@der-eismann The TCL team seems to have closed the ticket - is the latest version of TCL/TK working? |
@dvdmuckle @der-eismann Does the latest version fix it? It looks like they pushed .15 |
Gonna start on testing this now, will let you know if this fixes things tomorrow. |
So I just tested EDMC 5.12.0 with 8.6.15 of tkinter, and while I never had this particular error before, everything seems to be functional. Here's the PR with those changes for the Flatpak flathub/io.edcd.EDMarketConnector#55 |
For the sake of additional testing I'm going to revert the tkinter changes in the aforementioned PR and put those into a new branch to let @der-eismann test those as I can replicate the issue in this PR. Once that's done, I'll merge in the 5.12.0 release for the Flatpak. |
Describe the bug
Recently tkinter 8.6.14 was released. I tried updating it for the Flatpak version of EDMC (see flathub/io.edcd.EDMarketConnector#42), however some parts of the styling was off. I don't have any idea how this works and I don't know when this version would be included in "normal" Python distributions, but it might make sense to investigate this. Maybe you can give me a hint where to start? Or is it obsolete because of #2116?
In this case URLs are just way larger and also hovering Ship, System & Station on the main screen will cause the layout to change since the font size increases when being hovered.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Consistent style as was before
Screenshots
tkinter 8.6.13:
tkinter 8.6.14:
The text was updated successfully, but these errors were encountered: