Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling issues with tkinter 8.6.14 #2235

Open
der-eismann opened this issue May 13, 2024 · 9 comments
Open

Styling issues with tkinter 8.6.14 #2235

der-eismann opened this issue May 13, 2024 · 9 comments
Assignees
Labels
bug ui User Interface upstream Requires an upstream fix

Comments

@der-eismann
Copy link
Contributor

  • Version: 5.10.6
  • Game Version: Odyssey
  • OS: Linux Fedora 40
  • OS Locale: English
  • If applicable: Browser [e.g. chrome, safari]

Describe the bug
Recently tkinter 8.6.14 was released. I tried updating it for the Flatpak version of EDMC (see flathub/io.edcd.EDMarketConnector#42), however some parts of the styling was off. I don't have any idea how this works and I don't know when this version would be included in "normal" Python distributions, but it might make sense to investigate this. Maybe you can give me a hint where to start? Or is it obsolete because of #2116?
In this case URLs are just way larger and also hovering Ship, System & Station on the main screen will cause the layout to change since the font size increases when being hovered.

To Reproduce
Steps to reproduce the behavior:

  1. Run with tkinter 8.6.14

Expected behavior
Consistent style as was before

Screenshots

tkinter 8.6.13:
Bildschirmfoto vom 2024-05-13 20-15-12

tkinter 8.6.14:
Bildschirmfoto vom 2024-05-13 20-16-11

@der-eismann der-eismann added bug unconfirmed An unconfirmed bug labels May 13, 2024
@der-eismann
Copy link
Contributor Author

Opened this issue over at the tcl/tk repo: https://core.tcl-lang.org/tk/tktview/8162e9b7a90465f0b2a761c9515dfbc45d4b7e9f
Maybe it's a Linux issue, maybe it's just because of my 200% display scaling, let's see.

@dvdmuckle
Copy link
Contributor

For what it's worth, this doesn't happen on my machine, and I'm not using any scaling. I can test on my laptop that does have 200% scaling, but it sounds like that might be the cause.

@Rixxan Rixxan added the upstream Requires an upstream fix label May 14, 2024
@Rixxan Rixxan added this to the Pre-6.0 Changes milestone May 14, 2024
@Rixxan
Copy link
Contributor

Rixxan commented May 14, 2024

Given this is likely an upstream issue with TCL/TK, marking as such. Will monitor until TCL/TK either kicks it back or fixes it.

@der-eismann
Copy link
Contributor Author

For what it's worth, this doesn't happen on my machine, and I'm not using any scaling. I can test on my laptop that does have 200% scaling, but it sounds like that might be the cause.

Did you test this build? Would be great if you could test it on another device 🙂
I guess we could implement a workaround, but let's see what TCL/TK does first.

@Rixxan Rixxan self-assigned this May 22, 2024
@Rixxan Rixxan added ui User Interface and removed unconfirmed An unconfirmed bug labels May 22, 2024
@Rixxan
Copy link
Contributor

Rixxan commented May 30, 2024

@der-eismann The TCL team seems to have closed the ticket - is the latest version of TCL/TK working?
E: They haven't pushed .15 yet so we still have to wait I guess

@Rixxan
Copy link
Contributor

Rixxan commented Sep 24, 2024

@dvdmuckle @der-eismann Does the latest version fix it? It looks like they pushed .15

@dvdmuckle
Copy link
Contributor

Gonna start on testing this now, will let you know if this fixes things tomorrow.

@dvdmuckle
Copy link
Contributor

So I just tested EDMC 5.12.0 with 8.6.15 of tkinter, and while I never had this particular error before, everything seems to be functional. Here's the PR with those changes for the Flatpak flathub/io.edcd.EDMarketConnector#55

@dvdmuckle
Copy link
Contributor

dvdmuckle commented Sep 25, 2024

For the sake of additional testing I'm going to revert the tkinter changes in the aforementioned PR and put those into a new branch to let @der-eismann test those as I can replicate the issue in this PR. Once that's done, I'll merge in the 5.12.0 release for the Flatpak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ui User Interface upstream Requires an upstream fix
Projects
Status: Low priority
Development

No branches or pull requests

3 participants