Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDを使用しない場合でもグラフ出力していたのを修正 #430

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Dec 9, 2020

@okazy
Copy link
Contributor

okazy commented Feb 16, 2021

travisが落ちていたので再実行しました。
売り上げ集計関連でしたのでエラー内容メモしておきます。

There was 1 failure:
---------
1) AdminTotalCept: 売上集計画面を確認する
 Test  ctests/acceptance/admin/total/AdminTotalCept.php
 Step  See element {"id":"total-products"}
 Fail  Failed asserting that an array is not empty.
Scenario Steps:
 72. $I->seeElement({"id":"total-products"}) at ctests/acceptance/admin/total/AdminTotalCept.php:117
 71. // I expect 表の表示を確認する
 70. $I->click("非会員") at ctests/acceptance/admin/total/AdminTotalCept.php:114
 69. // I am going to 売上集計>商品集計>期間集計>非会員
 68. $I->seeElement({"id":"total-products"}) at ctests/acceptance/admin/total/AdminTotalCept.php:110
 67. // I expect 表の表示を確認する

@okazy okazy added this to the 2.17.2 milestone Feb 16, 2021
@okazy okazy merged commit afa8069 into EC-CUBE:master Feb 16, 2021
@okazy
Copy link
Contributor

okazy commented Feb 16, 2021

テストが通りましたのでマージしました。ありがとうございます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants