-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer update #4396
Merged
Merged
Composer update #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony3.4.30 で DoctrineBundle の依存が 1.11 → 1.12 へ変更となり, DoctrineCacheBundle から Symfony/Cache を利用するようになったため, デフォルトで ResultCache が有効になっている模様. APP_ENV=dev|test では不要なので明示的に array を指定する
nanasess
force-pushed
the
composer-update
branch
from
November 28, 2019 01:41
cafea2e
to
71aefe5
Compare
Codeception のテストはすべて通っているが、非推奨の警告が出ているためテストが落ちている模様 |
nanasess
force-pushed
the
composer-update
branch
from
December 9, 2019 03:34
3d0acab
to
7da3abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
課題(Problem)
APP_ENV=dev
の状態でも Doctrine Cache が有効になっており、カテゴリ管理画面のテストが失敗す実装に関する補足(Appendix)
APP_ENV=codeception
が指定されていたが、ユニットテストではキャッシュに影響でテストに失敗するため、APP_ENV=test
に変更するテスト(Test)
ユニットテストが通るのを確認
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目