Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip glb-only plots for hemispheric ts #460

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Skip glb-only plots for hemispheric ts #460

merged 1 commit into from
Jul 21, 2023

Conversation

forsyth2
Copy link
Collaborator

Follow up to #459 -- if a plot only uses glb data, with no option for hemispheric plotting, then it should not be plotted on the hemispheric time series.

@forsyth2 forsyth2 added the semver: small improvement Small improvement (will increment patch version) label Jul 20, 2023
@forsyth2
Copy link
Collaborator Author

@golaz @chengzhuzhang I found it most straightforward to leave the glb-only plots blank on the hemispheric time series pages. 1) It is very difficult to tell at the page setup level whether a plot will only have glb-data, 2) I think this actually looks better visually, as plots will be in the same row/col across all 3 (glb, n, s) for easy comparison.

Let me know if this is acceptable output/formatting:

glb:
image

n:
image

s:
image

@chengzhuzhang
Copy link
Collaborator

Hi Ryan, thanks for working on this. A small glitch: title of the temperature time-series plot for glb, N, S, all show global, it might be worth to fix..

@forsyth2
Copy link
Collaborator Author

Good catch, thanks @chengzhuzhang

@forsyth2 forsyth2 merged commit e1b517e into main Jul 21, 2023
@forsyth2 forsyth2 deleted the filter-glb-plots branch July 21, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: small improvement Small improvement (will increment patch version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants