You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rethink how testing is done in zppy & zppy-interfaces. zppy should simply test that it can invoke zppy-interfaces global-time-series. zppy-interfaces however should test that Global Time Series plots actually generate correctly.
Maybe we could have zppy test that zppy is passing in the right parameters and then have zppy-interfaces actually do the image comparisons of the plots, using pre-generated ts and mpas_analysis output.
The text was updated successfully, but these errors were encountered:
Maybe we could have zppy test that zppy is passing in the right parameters and then have zppy-interfaces actually do the image comparisons of the plots, using pre-generated ts and mpas_analysis output.
I think this is the best path forward, but there are two concerns:
This works fine for packages like e3sm_diags and zppy_interfaces where we can move the image comparison checking to those packages (indeed e3sm_diags already has that implemented). But what about mpas_analysis and ILAMB?
It's one thing to know the arguments are correct, but it's another to know the input data is available. Part of zppy's purpose is setting up the necessary input data for each package it calls. (This is the reason for the job dependency chaining). So yes, we could test the command line arguments or generated cfg (for diags) are correct, but how would we test that we've generated the correct input data and put it in the right place?
Rethink how testing is done in
zppy
&zppy-interfaces
.zppy
should simply test that it can invokezppy-interfaces global-time-series
.zppy-interfaces
however should test that Global Time Series plots actually generate correctly.Maybe we could have
zppy
test thatzppy
is passing in the right parameters and then havezppy-interfaces
actually do the image comparisons of the plots, using pre-generatedts
andmpas_analysis
output.The text was updated successfully, but these errors were encountered: