Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version patchlevel from svn revision to date #1565

Open
derekbruening opened this issue Nov 29, 2014 · 2 comments
Open

update version patchlevel from svn revision to date #1565

derekbruening opened this issue Nov 29, 2014 · 2 comments
Assignees

Comments

@derekbruening
Copy link
Contributor

With the move to git we no longer have a short monotonically increasing integer to use for the version patchlevel for unofficial builds (for identifying builds as well as allowing dependencies to be expressed between releases).

The proposal is to switch to using the date of the last commit. With our rebase workflow, the committer date (not author date) should fit our purposes.

For builds outside of a git repo, e.g., from a source tarball, we should support getting the patchlevel from a file. We should switch package.cmake to use this for official builds as well. If that file is not present and we're in a git repo, we'll then use the date of the last commit.

Getting something in place is high priority as the Windows build is broken due to this.

@derekbruening
Copy link
Contributor Author

Commit 0c81acf added the day of the last commit to solve the immediate build problem on Windows.

Leaving open for the packaging and source tarball support.

@derekbruening
Copy link
Contributor Author

GitHub has a feature "Download Zip" that lets people easily obtain the source files without any version control. This will be a pain to support, as A) it does not include git submodules and B) adding patchlevel support would require us to update a file on every commit. I propose that we simply do not support building from such zip files. I do not see any way to disable the feature from the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant