Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit_tests ExtensionServiceTest.InstallTheme fail under Dr. Memory Full mode #1339

Closed
derekbruening opened this issue Nov 28, 2014 · 3 comments

Comments

@derekbruening
Copy link
Contributor

From [email protected] on September 19, 2013 12:08:32

http://build.chromium.org/p/chromium.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/441/steps/memory%20test%3A%20unit_3/logs/stdio [ RUN ] ExtensionServiceTest.InstallTheme
[2428:3848:0919/040400:1032996250:ERROR:storage_partition_impl.cc(88)] Couldn't remove data of type 1 for origin chrome-extension://iamefpfkojoapidjnbafmgkgncegbkad/. Status: 11
[2428:3848:0919/040401:1032996781:ERROR:storage_partition_impl.cc(88)] Couldn't remove data of type 2 for origin chrome-extension://iamefpfkojoapidjnbafmgkgncegbkad/. Status: 11
e:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service_unittest.cc(832): error: Value of: actual_extension_count
Actual: 1
Expected: expected_extensions_count_
Which is: 2
E:\b\build\slave\chromium-dbg-win-drmemory-full-2\build\src\chrome\test\data\extensions\theme2.crx
e:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service_unittest.cc(996): error: Value of: GetPrefKeyCount()
Actual: 1
Expected: count
Which is: 2
e:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service_unittest.cc(832): error: Value of: actual_extension_count
Actual: 2
Expected: expected_extensions_count_
Which is: 3
E:\b\build\slave\chromium-dbg-win-drmemory-full-2\build\src\chrome\test\data\extensions\theme_with_extension.crx
e:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service_unittest.cc(996): error: Value of: GetPrefKeyCount()
Actual: 2
Expected: count
Which is: 3
[2428:3848:0919/040412:1033008231:WARNING:extension_error_reporter.cc(56)] Extension error: Package is invalid: 'CRX_VERSION_NUMBER_INVALID'.
e:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service_unittest.cc(996): error: Value of: GetPrefKeyCount()
Actual: 2
Expected: count
Which is: 3
[2428:3848:0919/040413:1033009604:WARNING:scoped_temp_dir.cc(17)] Could not delete temp dir in dtor.
[ FAILED ] ExtensionServiceTest.InstallTheme (47614 ms)

Cannot reproduce on my local machine, and the light mode on MFYI bot seems fine, so exclude it for now.

Original issue: http://code.google.com/p/drmemory/issues/detail?id=1339

@derekbruening
Copy link
Contributor Author

From [email protected] on September 19, 2013 16:39:29

I can reproduce.

** INFO native: works
** INFO full mode: fails
** INFO -no_check_uninitialized: works
** INFO -no_fastpath: works
** INFO no fastpath for floating-point instrs: works

So it's something to do w/ floats. Not sure yet exactly what though.

Status: Started
Owner: [email protected]

@derekbruening
Copy link
Contributor Author

From [email protected] on May 27, 2014 05:24:42

I've re-filed this under https://code.google.com/p/chromium/issues/detail?id=377702 since this reproduces under TSan as well.

@derekbruening
Copy link
Contributor Author

From [email protected] on May 27, 2014 08:35:51

I spent some time on this in the past but forgot to update the issue: this one seemed at first to perhaps be a bug in Dr. Memory but that was a red herring as it was non-deterministic and seemed to be something inherent in the test being fragile to time dilation. Repro under TSan corroborates that.

Status: NotABug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant