uninit read in NtUserEnumDisplayMonitors parameter value #4

[derekbruening]

From [email protected] on September 16, 2013 12:34:49

http://build.chromium.org/p/chromium.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/423/steps/memory%20test%3A%20unit_2/logs/stdio [----------] 1 test from MetricsLogTest
[ RUN ] MetricsLogTest.RecordEnvironment
Dr.M
Dr.M Error #1: UNINITIALIZED READ: reading 0x0018ef8c-0x0018ef90 4 byte(s) within 0x0018ef8c-0x0018ef90
Dr.M # 0 system call NtUserEnumDisplayMonitors parameter value #4
Dr.M # 1 anonymous namespace'::WriteScreenDPIInformationProto [chrome\browser\metrics\metrics_log.cc:320] \~~Dr.M~~ # 2 MetricsLog::RecordEnvironmentProto [chrome\browser\metrics\metrics_log.cc:783] \~~Dr.M~~ # 3 MetricsLog::RecordEnvironment [chrome\browser\metrics\metrics_log.cc:693] \~~Dr.M~~ # 4 MetricsLogTest::TestRecordEnvironment [chrome\browser\metrics\metrics_log_unittest.cc:136] \~~Dr.M~~ # 5 MetricsLogTest_RecordEnvironment_Test::TestBody [chrome\browser\metrics\metrics_log_unittest.cc:204] \~~Dr.M~~ # 6 testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [testing\gtest\src\gtest.cc:2051] \~~Dr.M~~ Note: @0:18:35.139 in thread 3480 \~~Dr.M~~ \~~Dr.M~~ Error#2: UNINITIALIZED READ: reading 0x0018f074-0x0018f078 4 byte(s) within 0x0018f074-0x0018f078 \~~Dr.M~~ # 0 system call NtUserEnumDisplayMonitors parameter value#4 \~~Dr.M~~ # 1anonymous namespace'::WriteScreenDPIInformationProto [chrome\browser\metrics\metrics_log.cc:320]
Dr.M # 2 MetricsLog::RecordEnvironmentProto [chrome\browser\metrics\metrics_log.cc:783]
Dr.M # 3 MetricsLogTest::TestRecordEnvironment [chrome\browser\metrics\metrics_log_unittest.cc:134]
Dr.M # 4 MetricsLogTest_RecordEnvironment_Test::TestBody [chrome\browser\metrics\metrics_log_unittest.cc:205]
Dr.M # 5 testing::internal::HandleExceptionsInMethodIfSupportedtesting::Test,void [testing\gtest\src\gtest.cc:2051]
Dr.M Note: @0:18:35.513 in thread 3480
[ OK ] MetricsLogTest.RecordEnvironment (1232 ms)
[----------] 1 test from MetricsLogTest (1232 ms total)

Original issue: http://code.google.com/p/drmemory/issues/detail?id=1333

[derekbruening]

From [email protected] on September 16, 2013 14:34:17

This issue was closed by revision r1553 .

Status: Fixed

[derekbruening]

From [email protected] on November 22, 2013 08:55:32

To add more information: the ReactOS entry is incorrect and does not match real Windows. As part of issue #484 I discovered this but forgot to update the #parameters from the script output that processed ntuser.h.

The EnumDisplayMonitors library routine goes straight to the Nt syscall on both Win7 and XP64.