3dview wrapper 2018 #1999
Merged
3dview wrapper 2018 #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiyunShang
approved these changes
Aug 13, 2018
AndyDu1985
added a commit
that referenced
this pull request
Aug 14, 2018
Merge pull request #1999 from ksobon/3dview-wrapper-2018
ZiyunShang
added a commit
that referenced
this pull request
Dec 7, 2018
AndyDu1985
pushed a commit
that referenced
this pull request
Dec 10, 2018
ZiyunShang
added a commit
to ZiyunShang/DynamoRevit
that referenced
this pull request
Dec 10, 2018
…018" This reverts commit 535c8ba.
ZiyunShang
added a commit
to ZiyunShang/DynamoRevit
that referenced
this pull request
Dec 10, 2018
3dview wrapper 2018
ZiyunShang
added a commit
to ZiyunShang/DynamoRevit
that referenced
this pull request
Dec 10, 2018
3dview wrapper 2018
AndyDu1985
pushed a commit
that referenced
this pull request
Dec 11, 2018
AndyDu1985
pushed a commit
that referenced
this pull request
Dec 18, 2018
* Change RevitAPI path to match D4R CICD * update version to 27 resolve CICD break * resolve Nugets NET47 updates * Revert "Merge pull request #1999 from ksobon/3dview-wrapper-2018" This reverts commit 535c8ba. * Delete DynamoPlayer from D4R CICD * update version to 30 * Set 5 tests to ignore because of DynamoRaaS removed * Add Change Log to track each change in version upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This addresses this issue:
#1636
#2002
It also addresses the issue of plain old skipping 3d view templates from any selection and wrapper routines.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
This used to be a PR but i messed up so here it is again. I ran tests for all relevant classes: