Fix regression in FamilyType.ByGeometry Node (#3067)

* CP fix for FamilyType.ByGeometry * Update version / changelog
DynamoDS · Apr 30, 2024 · f2e5ff2 · f2e5ff2
1 parent 44965a9
commit f2e5ff2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/.version b/.version
@@ -1 +1 @@
-0.6.17
+0.6.18
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 0.6.18
+* Fix regression on FamilyInstance.ByGeometry node
+
 ## 0.6.17
 * Version back DynamoRevit to 3.1
 

diff --git a/src/Libraries/RevitNodes/GeometryConversion/ProtoToRevitSolid.cs b/src/Libraries/RevitNodes/GeometryConversion/ProtoToRevitSolid.cs
@@ -176,6 +176,8 @@ public static Autodesk.Revit.DB.FamilySymbol ToRevitFamilyType(
             var solids = GetSolidsFromElement(familyDocument.GetElement(importedElementId));
 
             // delete imported sat
+            // first unpin the element to avoid an exception when deleting the SAT import
+            familyDocument.GetElement(importedElementId).Pinned = false;
             familyDocument.Delete(importedElementId);
             System.IO.File.Delete(tempFile);