Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address refactor bug introduced in #9567 #9580

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

alfarok
Copy link
Contributor

@alfarok alfarok commented Mar 15, 2019

Purpose

This PR address a bug introduced in #9567 where the method EndAndStartCtrlConnection() in DynamoModelCommands.cs was renamed to BeginCreateConnections() and where the method EndAndStartCtrlConnection() in StateMachine.cs was renamed to BeginCreateConnections(). These switch statements were updated to call the wrong methods with similar naming. All the RecordedTests are now passing.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @QilongTang

@mjkkirschner
Copy link
Member

LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Mar 15, 2019
@alfarok alfarok merged commit 3a968f5 into DynamoDS:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants