-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more core only (no WPF refs) tests to net6 slns pt3 #14027
Conversation
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' "> | ||
<PackageReference Include="NUnit" Version="2.6.3" /> | ||
<PackageReference Include="NUnitTestAdapter" Version="2.3.0" ExcludeAssets="all" /> | ||
<Reference Include="System" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjkkirschner Does it mean that System libraries are just called when the Target Framework is .NET 4.8? So, I can assume then that if the Target Framework is .NET 6 doesn't work or am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these references are no longer required when targeting .net6 - I believe some of them have been moved to nuget packages - not system
of course, but some of the other types have moved to different assemblies.
<PackageReference Include="DynamoVisualProgramming.LibG_229_0_0" Version="2.18.0.1400"/> | ||
<PackageReference Include="NUnitTestAdapter" Version="2.3.0" ExcludeAssets="all" /> | ||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't these references (LibG and Test.Sdk) need to be there for all targets? I see that they've been removed altogether, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aparajit-pratap - this looks like a mistake, I guess the tests still pass as other test assemblies bring those deps in - but I'll revert this deletion.
Purpose
Adds the following test projects to the Net6 Solutions:
There is a failing test:
https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/9136/
but it's that strange native exception regarding loading the geometry bins, only seems to repro when tests run in parallel.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Adds 5 test assemblies to the net6 .slns
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of