Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizeMode behaviour is inconsistent between 8.5.12 and 8.6.0 #922

Closed
Dimous opened this issue Aug 29, 2022 · 9 comments
Closed

resizeMode behaviour is inconsistent between 8.5.12 and 8.6.0 #922

Dimous opened this issue Aug 29, 2022 · 9 comments
Labels

Comments

@Dimous
Copy link

Dimous commented Aug 29, 2022

Describe the bug
Image resize behaviour is inconsistent between versions.

To Reproduce

<FastImage 
resizeMode={
FastImage.resizeMode.cover
}
source={
{
uri: "https://azbykamebeli.ru/upload/resize_cache/iblock/04d/748_900_1/04d58535526351ab165c5c11983f2791.jpg",
cache: FastImage.cacheControl.web,
priority: FastImage.priority.high
}
}
style={
{
width: "100%",
minHeight: 469.40028989251283
}
}
/>

Expected behavior
Image resize behaviour to be consistent between versions.

Screenshots

v8.5.12

Screenshot_20220829-215717_azbykamebeli

v8.6.0

Screenshot_20220829-220403_azbykamebeli

Dependency versions

  • React Native version: ^0.69.5
  • React version: ^18.2.0
  • React Native Fast Image version: ^8.6.0

Changing FastImage.resizeMode.cover to FastImage.resizeMode.contain solves the problem, but the point is that the behavior shouldn't have changed between versions.

@Dimous Dimous added the bug label Aug 29, 2022
@Dimous Dimous changed the title Image is shown differently in 8.5.12 and 8.6.0 resizeMode behaviour is inconsistent between 8.5.12 and 8.6.0 Aug 29, 2022
@bhaltair
Copy link

bhaltair commented Sep 1, 2022

same problem

@djMax
Copy link

djMax commented Sep 2, 2022

Is this just a case of the default value changing? (agree it shouldn't have)

@djMax
Copy link

djMax commented Sep 2, 2022

(I ask that because if all we need to do is specify contain everywhere there was no value, that's an easy-ish thing to do. But if the change in behavior is more complex...)

@jihokim2
Copy link

jihokim2 commented Oct 11, 2022

Same Problem.
And AutoSizeExample is not working at 8.6.x in andorid.

@forkball
Copy link

Bump! This is happening in my project as well.

@esthefanielanza-sothebys
Copy link

esthefanielanza-sothebys commented Nov 25, 2022

I'm having the same issue on android devices

Dependency versions:
"react-native": "0.67.5"
"react": "17.0.2",
"react-native-fast-image": "^8.3.4"

@saif-o99
Copy link

saif-o99 commented Aug 2, 2023

anyone found a solution?

@Dimous
Copy link
Author

Dimous commented Aug 3, 2023

This package is dead.

@Dimous Dimous closed this as completed Aug 3, 2023
@saif-o99
Copy link

saif-o99 commented Aug 3, 2023

Just converted to react-native-image-cache . seems alot better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants