Error Detection Supersedes Valid Content Response

[dahlbyk]

https://developers.dwolla.com/guides/business-verified-customer/handle-verification-statuses#determining-verification-documents example response documents a scenario where errors is expected along with valid content and a 200 OK response body.

This regex matches on that response, suppressing valid Content (important to be able to repair the Customer) in the presence of errors:

dwolla-v2-csharp/Dwolla.Client/Rest/ResponseBuilder.cs

Lines 29 to 31 in 393fd17

	return ErrorRegex.IsMatch(rawContent)
	? Error<T>(response, JsonConvert.DeserializeObject<ErrorResponse>(rawContent), rawContent)
	: new RestResponse<T>(response, JsonConvert.DeserializeObject<T>(rawContent), rawContent);

Expected behavior: either...

• 200 OK response from GET Customer always deserializes the Customer into RestResponse<Customer>.Content.
• 200 OK API response shouldn't include errors. In this case, the DBA required error is also communicated via _links['upload-dba-document'].

Actual behavior:

• 200 OK response from GET Customer returns a RestResponse<Customer> with Content = null.
• 200 OK response includes errors, which I don't recall seeing for other document-required scenarios.

[ShreyaThapa]

Hi @dahlbyk -- thanks for reporting! We were table to test internally and confirm that this is a bug. The expected behavior is that the Content should always be populated for 200 Ok response even if it contains an error object.

We have logged a bug ticket on our end to work on a fix, however, we do not anticipate to have it rolled out this week or the next.

In the meantime, feel free to clone the repo and update the logic so that you can continue using the SDK in your application. We also appreciate pull requests if you would like to contribute to the repo!

Thank you and Happy Holidays!

[dahlbyk]

We were able to patch and work around this: https://github.com/Stratafolio/dwolla-v2-csharp/tree/gh-47-hack.

But a more correct fix seems like it would need to add _embedded to BaseResponse so errors are available in the successful response.

[ShreyaThapa]

Thanks @dahlbyk!

Logging the proposed two-fold solution for reference:

• add _embedded to BaseResponse
• populate Content for all 200 Ok responses including ones that have an error object

[ShreyaThapa]

This issue has been fixed in the latest release 5.4.0.

[dahlbyk]

Great, thanks!

(Fixed in #48)