From 90ad4f17f4598a3dee57779dad1ac490d8ff85f8 Mon Sep 17 00:00:00 2001 From: Brian Holt Date: Thu, 14 Mar 2024 15:04:07 -0500 Subject: [PATCH] correct remaining warnings --- .../com/dwolla/util/async/finagle/TracedThriftClient.scala | 4 +--- .../scala/com/dwolla/util/async/finagle/ZipkinTracer.scala | 4 ++-- .../scala/com/dwolla/util/async/finagle/ThriftClient.scala | 4 +--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/TracedThriftClient.scala b/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/TracedThriftClient.scala index 25661bb35..b2ade11fc 100644 --- a/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/TracedThriftClient.scala +++ b/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/TracedThriftClient.scala @@ -11,8 +11,6 @@ import com.dwolla.util.async.twitter._ import com.twitter.util.{Closable, Future} import natchez.Trace -import scala.language.reflectiveCalls - /** * Build a Finagle Thrift client using the given Thrift * method-per-endpoint algebra and the given destination. Optionally, @@ -40,7 +38,7 @@ object TracedThriftClient { */ def apply[Alg[_[_]] <: AnyRef {def asClosable: Closable}] = new PartiallyAppliedThriftClient[Alg]() - class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[TracedThriftClient](val dummy: Unit = ()) extends AnyVal { + class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[TracedThriftClient](val dummy: Boolean = false) extends AnyVal { /** * @param name the local service name to be set on the Zipkin tracer * @param dest the destination whence the Thrift interface is being served. diff --git a/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/ZipkinTracer.scala b/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/ZipkinTracer.scala index 6f93873b8..740128490 100644 --- a/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/ZipkinTracer.scala +++ b/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/ZipkinTracer.scala @@ -47,9 +47,9 @@ class ZipkinTracerConfig(val host: SocketAddress[_], this( SocketAddress(host"127.0.0.1", port"9411"), alwaysSample, - false, + tlsEnabled = false, localServiceName, - true, + compressionEnabled = true, "zipkin", "/api/v2/spans" ) diff --git a/twitter-finagle/src/main/scala/com/dwolla/util/async/finagle/ThriftClient.scala b/twitter-finagle/src/main/scala/com/dwolla/util/async/finagle/ThriftClient.scala index bdcf6ccfe..2588eec33 100644 --- a/twitter-finagle/src/main/scala/com/dwolla/util/async/finagle/ThriftClient.scala +++ b/twitter-finagle/src/main/scala/com/dwolla/util/async/finagle/ThriftClient.scala @@ -8,12 +8,10 @@ import com.dwolla.util.async.twitter._ import com.twitter.finagle.Thrift import com.twitter.util.{Closable, Future} -import scala.language.reflectiveCalls - object ThriftClient { def apply[Alg[_[_]] <: AnyRef {def asClosable: Closable}] = new PartiallyAppliedThriftClient[Alg]() - class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[ThriftClient] (val dummy: Unit = ()) extends AnyVal { + class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[ThriftClient] (val dummy: Boolean = false) extends AnyVal { def apply[G[_] : Async](dest: String) (implicit AlgR: Alg[ReaderT[Future, Alg[Future], *]],