Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Deleting a message crashes the app #704

Closed
2 tasks done
mathiasayivor opened this issue Oct 14, 2024 · 4 comments · Fixed by #712
Closed
2 tasks done

[BUG] Deleting a message crashes the app #704

mathiasayivor opened this issue Oct 14, 2024 · 4 comments · Fixed by #712
Assignees
@azr-arch
Labels
2 weeks Not more than 2 weeks to raise a PR assigned bug Something isn't working fullStack this issue requires knowlegde of both frontend and backend hacktoberfest 🏁 status: ready for dev issue is ready to be worked on

Comments

@mathiasayivor
Copy link
Collaborator

Description

Whenever I'm chatting and I try deleting a message, the app crashes with a console error: Room not found!

Screenshots

No response

Additional information

No response

🥦 Browser

Google Chrome

👀 Have you checked if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None
@mathiasayivor mathiasayivor added bug Something isn't working hacktoberfest 🚦 status: awaiting approval waiting for maintainer to accept issue as ready to work labels Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

To reduce notifications, issues are locked until they are valid/approved and to be assigned. In the meantime read the contributing guidelines -> https://github.com/Dun-sin/Whisper/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@Dun-sin Dun-sin added up for grabs anyone can ask to work on this fullStack this issue requires knowlegde of both frontend and backend 2 weeks Not more than 2 weeks to raise a PR 🏁 status: ready for dev issue is ready to be worked on and removed 🚦 status: awaiting approval waiting for maintainer to accept issue as ready to work labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you.

@github-actions github-actions bot unlocked this conversation Oct 15, 2024
@azr-arch
Copy link
Contributor

Can i get this?

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 20, 2024

Can i get this?

Sure @azr-arch, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions on the discord server. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

@Dun-sin Dun-sin added assigned and removed up for grabs anyone can ask to work on this labels Oct 20, 2024
@azr-arch azr-arch mentioned this issue Oct 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azr-arch azr-arch

Labels
2 weeks Not more than 2 weeks to raise a PR assigned bug Something isn't working fullStack this issue requires knowlegde of both frontend and backend hacktoberfest 🏁 status: ready for dev issue is ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: crash when deleting a message azr-arch/Whisper
3 participants
@mathiasayivor @Dun-sin @azr-arch