Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task CPU usage in M122 report can exceed 100% #1005

Closed
dc42 opened this issue May 14, 2024 · 2 comments
Closed

Task CPU usage in M122 report can exceed 100% #1005

dc42 opened this issue May 14, 2024 · 2 comments
Assignees
@dc42
Labels
Done - Needs Testing
Milestone
3.5.2

Comments

@dc42
Copy link
Collaborator

dc42 commented May 14, 2024

In the M122 report the total reported CPU usage and individual task CPU usage can exceed 100% if the machine has been running for more than about 90 minutes. This is caused by the 32-bit CPU time counter overflowing.
@dc42 dc42 added this to the 3.5.2 milestone May 14, 2024
@dc42 dc42 self-assigned this May 14, 2024
@dc42
Copy link
Collaborator Author

dc42 commented May 14, 2024 •
edited
Loading

Fixed in projects FreeRTOS, RepRapFirmware and Duet3Expansion but not yet committed, pending testing. The tick counter and associated variables are now 64 bit.

@T3P3 T3P3 changed the title Task CPU usage in M122 report can exceed 10% Task CPU usage in M122 report can exceed 100% May 14, 2024
@dc42
Copy link
Collaborator Author

dc42 commented May 15, 2024

Tested and working in 3.5-second-alt-is branch, using the code merged from the 3.5-dev branch.

@dc42 dc42 closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dc42 dc42

Labels
Done - Needs Testing
Projects
None yet
Milestone
3.5.2
Development

No branches or pull requests
1 participant
@dc42