Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set new time for "endTime" does not work; BUG #22

Open
salierykuba opened this issue Jan 1, 2024 · 4 comments
Open

Set new time for "endTime" does not work; BUG #22

salierykuba opened this issue Jan 1, 2024 · 4 comments

Comments

@salierykuba
Copy link

timeRangePicker.startTime = TimeRangePicker.Time(12, 0) : work ok

timeRangePicker.endTime = TimeRangePicker.Time(12, 0) : does not work, does nothing

@tomleejumah
Copy link

Actually the bug or rather the design is that you cant use EndTime or StartTime together since they all reference to same thumb inside onCreate but when you slide around it works for both thumbs...I wish It can be fixed.

@Droppers
Copy link
Owner

I don't understand the issue, can you elaborate, or point to the incorrect code location? Thank you :)

@tomleejumah
Copy link

I don't understand the issue, can you elaborate, or point to the incorrect code location? Thank you :)

here is a link to myGist I have highlighted the "bug" https://gist.github.com/Ttoml33/0640f5950faca65014983ab17c76ed2e

@salierykuba
Copy link
Author

Actually the bug or rather the design is that you cant use EndTime or StartTime together since they all reference to same thumb inside onCreate but when you slide around it works for both thumbs...I wish It can be fixed.

thank you; That's exactly the problem; For example; When starting the activity I want to be able to set the endTime and startTime at the time I decide; but it doesn't work, as you explain.
The only thing I could do to fix it was to set the endTime using: timeRangePicker.endTime.totalMinutes. It works, but it is not correct.
I also hope they fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants