Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide title when enable the BigFont/BigDisplay in FloorMapScreen #1149

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Hide title when enable the BigFont/BigDisplay in FloorMapScreen #1149

wants to merge 3 commits into from

Conversation

kosenda
Copy link
Contributor

@kosenda kosenda commented Sep 10, 2023 •
edited
Loading

Issue

Overview (Required)

  • Text can now be resized and displayed by creating text for automatic text resizing.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Pixel 7 Pro API 34 (Emulator)

Settings Before After

@github-actions
Copy link

Hi @kosenda! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

github-actions bot commented Sep 10, 2023 •
edited
Loading

Test Results

218 tests   218 ✔️  5m 55s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 8a77bdf.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 07:40 Inactive
@kosenda kosenda mentioned this pull request Sep 10, 2023
Open
@kosenda kosenda marked this pull request as ready for review September 10, 2023 08:00
@kosenda kosenda requested a review from a team as a code owner September 10, 2023 08:00
@kosenda kosenda mentioned this pull request Sep 10, 2023
Open
@takahirom
Copy link
Member

Could you add screenshot tests for this? Maybe we could break this unexpectedly 🙏

@kosenda kosenda marked this pull request as draft September 10, 2023 11:33
@github-actions
Copy link

Snapshot diff report

File name Image
FloorMapScreenTest.s
mallFontScaleShot_co
mpare.png
FloorMapScreenTest.h
ugeFontScaleShot_com
pare.png
FloorMapScreenTest.l
argeFontScaleShot_co
mpare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 12:13 Inactive
@kosenda kosenda marked this pull request as ready for review September 10, 2023 12:21
takahirom
takahirom reviewed Sep 10, 2023
View reviewed changes
core/ui/src/commonMain/kotlin/io/github/droidkaigi/confsched2023/ui/AutoSizableText.kt
private const val CONTRACTION_RATIO = 0.95f

/**
* ref: https://blog.canopas.com/autosizing-textfield-in-jetpack-compose-7a80f0270853
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the references! Is this your original implementation? Otherwise, just to clarify, could you please tell us if this code complies with our license? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can say that it is 100% original, as I am sure that I am referring to an article.
However, I would like to say that there are many parts that I came up with or researched and created myself, so there is no problem.

I don't see anything in the article (Medium) or in the sample code on GitHub about licensing, and I honestly don't know what to do if the above is insufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom left review comments

@upon0426 upon0426 Awaiting requested review from upon0426 upon0426 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide title when enable the BigFont/BigDisplay in FloorMapScreen
2 participants
@kosenda @takahirom