Add share button to the Session Detail Screen #578
Conversation
rkowase
changed the title
| session.room.name, | ||
| speakers) | ||
| val url = resources.getString(R.string.session_share_url, sessionId) | ||
| putExtra(Intent.EXTRA_TEXT, "$title\n$url") |
There was a problem hiding this comment.
example
ConstraintLayout, now and future at Room 6 by Nicolas Roard, John Hoford, thagikura
https://droidkaigi.jp/2018/timetable?session=16988
There was a problem hiding this comment.
[Q] Should I add a hashtag or any text?
There was a problem hiding this comment.
Please wait. I will talk with staff🙏
There was a problem hiding this comment.
The staff has decided to #droidkaigi_room1...#droidkaigi_room7 #droidkaigi_hall.
There was a problem hiding this comment.
I added
e.g.
ConstraintLayout, now and future (Nicolas Roard, John Hoford, thagikura) #droidkaigi_room6
https://droidkaigi.jp/2018/timetable/?session=16988
| * | ||
| * e.g. #droidkaigi_hall, #droidkaigi_room1, ... | ||
| * | ||
| * @param roomName The Room name |
| * e.g. #droidkaigi_hall, #droidkaigi_room1, ... | ||
| * | ||
| * @param roomName The Room name | ||
| * @return A hash tag |
| @@ -77,13 +78,22 @@ class SessionDetailFragment : Fragment(), Injectable { | |||
| binding.toolbar.setNavigationOnClickListener { activity?.finish() } | |||
| } | |||
|
|
|||
| private fun bindSession(session: Session.SpeechSession) { | |||
| private fun bindSession(session: Session.SpeechSession, sessionId: String) { | |||
There was a problem hiding this comment.
I think you can get sessionId by session.id.
What do you think? 👀
|
I think two FABs are bad. Because FAB should be primary action. 👀 I think we should use menu icon. |
| private fun generateSharedText(session: Session.SpeechSession, sessionId: String): String { | ||
| var speakerList = listOf<String>() | ||
| session.speakers.forEach { speakerList += it.name } | ||
| val speakers = speakerList.joinToString(", ") |
There was a problem hiding this comment.
How about this? 👀
session.speakers.map { it.name }.joinToString(", ")
There was a problem hiding this comment.
Thanks for suggestion. I'll simplify.
| @@ -37,6 +37,11 @@ | |||
| <string name="session_finished">Finished Session</string> | |||
| <string name="session_go_to_feedback">Go To Feedback</string> | |||
| <string name="session_current_badge" translatable="false">NOW!</string> | |||
| <string name="session_share_url" translatable="false">https://droidkaigi.jp/2018/timetable?session=%s</string> | |||
There was a problem hiding this comment.
Thanks for translatable="false" 👍
I agree. I'll use menu icon instead of FAB. |
|
I replaced. Screenshot
|
Issue
Overview (Required)
Links
Screenshot