Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements #44

Open
Witoso opened this issue Jun 9, 2018 · 10 comments
Open

Requirements #44

Witoso opened this issue Jun 9, 2018 · 10 comments
Labels

Comments

@Witoso
Copy link
Contributor

Witoso commented Jun 9, 2018

It's necessary to add minimal requirements of the app in the documentation/README.

For example:

  • python version (i.e. documentation generation fails with Python 3.5.1)
  • OS (I guess it's debian based app)
@Witoso Witoso added the docs label Jun 9, 2018
@kwarunek
Copy link
Contributor

kwarunek commented Jun 10, 2018

Fair point. The application has only one requirement (besides python modules): python3.5+ . It runs on different distros without any hassle. Windows and macOS and other are supported just like python itself on these platforms.

@Witoso
Copy link
Contributor Author

Witoso commented Jun 10, 2018

  1. Are you sure about 3.5? PostgresDrivers (https://github.com/DreamLab/vmshepherd-runtime-postgres-driver):

Library requires (as well as VmShepherd itself) python 3.6 or later.

  1. As for the OS requirement, we need to figure out how to install graphviz in make (sudo apt-get install -y graphviz libgraphviz-dev pkg-config) because now it fails on other platforms.

@Witoso
Copy link
Contributor Author

Witoso commented Jun 10, 2018

Not sure, but I think source env/bin/activate; will fail on Windows. Also running Makefile will not be trivial on that platform.

@kwarunek
Copy link
Contributor

Requirements of the plugins may differ, the Postgres is thrid-party one.. so it does not apply to this docs.

And my bad, to be correct 3.6 is required :) even without pg.

@kwarunek
Copy link
Contributor

graphviz is not required to run VmShepherd

@kwarunek
Copy link
Contributor

kwarunek commented Jun 10, 2018

Makefile is a completely different subject. Since Makefile can be run (and source will work as well) with cygwin or nmake or ... I've not seen a much of docs in other projects to handle this matter.

Target audience is tech-aware.

@kwarunek
Copy link
Contributor

kwarunek commented Jun 10, 2018

I understand that it needs a bit more changes (especially in docs), but as a quick hint I added some info in the README.rst in #45

@evemorgen
Copy link
Contributor

evemorgen commented Jun 10, 2018

I bet we do not have any interest in supporting this app under Windows, however it should be pointed out in docs. Most other Linux based OSes are fine, probably

@kwarunek
Copy link
Contributor

kwarunek commented Jun 10, 2018

It isn't a matter of interest, rather than does it require more effort - currently VmShpeherd is working under windows (https://vimeo.com/274380573 - I know you wouldn't believe that I run it on Windows ;) ). Linux-based statement is biased IMHO.

I will update travis.yml to include mac, win, bsd as well

@Witoso
Copy link
Contributor Author

Witoso commented Jun 11, 2018

I think we can draw a few things from this discussion.

  1. VmShepherd is awesome ;)
  2. We need a requirements section for running the app.
  3. We need a requirements section for developing the app. BTW. if a developer will run the make run command on a non debian linuxes, it will fail (graphviz package).
  4. Ergo, we need to separate doc buidling (and doc requirements) from running the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants