Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trailing commas for Enums (similar to SA1413) #2239

Closed
RalfKoban opened this issue Dec 2, 2016 · 3 comments
Closed

Use trailing commas for Enums (similar to SA1413) #2239

RalfKoban opened this issue Dec 2, 2016 · 3 comments
Assignees
@dlemstra
Labels
enhancement fixed
Milestone
1.1.0 Beta 2

Comments

@RalfKoban
Copy link
Contributor

Similar to the new introduced maintainability rule SA1413 it would be nice to have such kind of rule for enum members as well (just to be consistent here).
It may also be less work for a reviewer as he can concentrate on the lines that changed but not the one that just got a trailing comma.
@sharwell
Copy link
Member

sharwell commented Dec 2, 2016

👍 but I would prefer to just treat enums as lists for the purpose of the existing rule.

@vweijsters
Copy link
Contributor

👍 I would also prefer to extend SA1413 to cover this case as well.

@RalfKoban
Copy link
Contributor Author

Would be nice if SA1413 gets extended to cover this case as well.

@dlemstra dlemstra mentioned this issue Dec 6, 2016
Merged
@sharwell sharwell added this to the 1.1.0 Beta 2 milestone Dec 7, 2016
@sharwell sharwell mentioned this issue Jul 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlemstra dlemstra

Labels
enhancement fixed
Projects
None yet
Milestone
1.1.0 Beta 2
Development

No branches or pull requests
4 participants
@sharwell @dlemstra @vweijsters @RalfKoban