Implement SA1315: ParametersShouldMatchInheritedNames

[sharwell]

Category: Naming
Title: Parameters should match inherited names
Description: When a method overrides a method from a base class, or implements an interface method, the parameter names of the overriding method should match the names in the base definition.

This rule is an enforcement of the special case added to SA1313 in #1372.

[bexxx]

This is a "duplicate" to CA1725 of FxCop (https://msdn.microsoft.com/en-us/library/ms182251.aspx).
Although I like to have it in StyleCop :)

[sharwell]

💭 Maybe treat this as a duplicate of dotnet/roslyn-analyzers#457, but then we don't have control over the release process. Or we could implement it as a new StyleCop rule and contribute the result back for the FxCop port.

[sharwell]

Looks like the FxCop port to Roslyn is looking back at us as well:

Notes:

See if StyleCop has implemented it

[bexxx]

Let's do it :). You can assign the diagnostic part to me if we agree to do it. I will look into the renaming part of the fix afterwards.

[vweijsters]

👍 I'd say we go for it.

[nbarbettini]

👍

[pdelvo]

Im grabbing this.

[vweijsters]

Based on the work of @pdelvo (#2015) I created an implementation for roslyn-analyzers (dotnet/roslyn-analyzers#911).

If we decide to include it in StyleCop analyzers as well, our implementation should match the one in roslyn-analyzers.

I've marked this as needs discussion again to determine if we want to include it.