Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Forward ref to ModalBody #841

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

pawelgrimm
Copy link
Contributor

@pawelgrimm pawelgrimm commented Sep 3, 2024

Short description

We are adding ref forwarding to ModalBody. This will allow consumers to gain a reference to the scrollable container within the ModalBody, which might be relevant for things like virtualization.

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Minor version update for a new, backwards compatible feature.

@pawelgrimm pawelgrimm marked this pull request as ready for review September 4, 2024 17:58
@pawelgrimm pawelgrimm self-assigned this Sep 4, 2024
@pawelgrimm pawelgrimm added the Show label Sep 4, 2024
@pawelgrimm pawelgrimm merged commit c010b85 into main Sep 4, 2024
2 checks passed
@pawelgrimm pawelgrimm deleted the pawel/foundation/forward-ref-modal-components branch September 4, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants