Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace request package #261

Open
Revadike opened this issue Feb 2, 2021 · 2 comments · May be fixed by #230
Open

Replace request package #261

Revadike opened this issue Feb 2, 2021 · 2 comments · May be fixed by #230
Milestone
v4

Comments

@Revadike
Copy link
Contributor

Revadike commented Feb 2, 2021

The package request has been deprecated for a while now and steamcommunity still uses it.
I suggest you add this to your v4 todo list (maybe also merge my PR while you're at it).
Anyway, there are several options to replace request with.
Personally, I'd recommend got, since it's as feature-rich and easy to use as request was, especially the easy cookie-support with tough-cookie.
But you can compare some of the most popular alternatives with this nice matrix:
https://www.npmjs.com/package/got#comparison
@Revadike Revadike mentioned this issue Jul 22, 2021
Open
@DoctorMcKay
Copy link
Owner

Added to todo list in the v4 PR, so I'm going to close this.

@DoctorMcKay DoctorMcKay linked a pull request Jul 22, 2021 that will close this issue
v4 #230
Draft
@DoctorMcKay
Copy link
Owner

Or I guess I could just use github properly.

@DoctorMcKay DoctorMcKay reopened this Jul 22, 2021
@DoctorMcKay DoctorMcKay added this to the v4 milestone Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4
Development

Successfully merging a pull request may close this issue.

v4 DoctorMcKay/node-steamcommunity
2 participants
@DoctorMcKay @Revadike