Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues tab displays problems with node_modules READMEs #56

Closed
UsAndRufus opened this issue Sep 12, 2023 · 2 comments
Closed

Issues tab displays problems with node_modules READMEs #56

UsAndRufus opened this issue Sep 12, 2023 · 2 comments

Comments

@UsAndRufus
Copy link

UsAndRufus commented Sep 12, 2023

Problem

The desktop app is flagging almost 200 issues with our project. Most if not all are isseus with READMEs in the node_modules directory. Obviously, we don't own these and they are not included in the final build of the site.

Currently, the issues list is basically useless given the quantity of noise.

Example

Screenshot 2023-09-12 at 15 57 36

Proposed solution

Two ideas:

  1. Add an ignores key to doctave.yaml that allows you to specify directories to ignore. This should come with node_modules already added
  2. Ignore node_modules by default and don't allow any customisation
@begleynk
Copy link
Member

Hi @UsAndRufus!

Would you be able to email me at [email protected] about this issue? This repo is no longer related to the Doctave.com product. See #51 for details.

But in short, the current Doctave desktop app (not this repo's project) looks at all .md files that it finds. It uses the directory that contains the doctave.yaml file as the root of the project, and searches sub-folders recursively. ignore is one option, but I'd love to understand your project structure to give a better answer.

If you email me I'll get back to you with more details.

I'll close this ticket since it's not relevant to this repo any more.

@UsAndRufus
Copy link
Author

Apologies, I tried to make sure they were the same project. Will email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants