-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display tags on each document on the course view #295
base: main
Are you sure you want to change the base?
Conversation
For context, see #251 What does it look like on mobile ? Especially with a lot of tags on the same document ? |
For the color I think we should choose color more distinct to each other, and as I propose maybe just have an icon related to a filter and just display the icon with the right color cool simplify the ui |
As maintainer, i'm against the color as they are now, it's too distracting and has no intrinsic meaning, without any clear benefit. If we want to go further with this PR, we should find a better way to color (or maybe even not color) the tags. But i like the layout and that if works well with a line break on small screens 🚀
I don't understand the phrase, could you maybe do a mockup of what you are envisioning ? My feeling is this PR is not mature enough as we haven't even decided what the UI should look like yet. It merits a longer discussion first. I'll move this to a draft. Edit: i know this PR was not a lot of work so this edit might not really apply but... For a subject is know to need a discussion, like this one where a ticket (stating the color/UI clutter problems) is already open, cf #251), it's better to first discuss, make mockups and agree and then implement. |
I don't really get why it becomes an issue now, before the tags as been always showed like that. Actually there is no way to distinct the different type of documents easily, so maybe it's not the perfect solution but it's a good work-a-round until we find a better solution. |
This is the kind of information that would have been great to point in the original ticket (#251). If it's the case, this clearly increases the priority of this ticket. Could you share the results of the form somewhere (another issue just for that would be great :) )
We always have done like that is not a valid reason to keep going.
I do get that you want to show the tags. I do too ! It is just that showing them with bright colored pills is worse than not showing them. We, as developpers have a tendency to want to display everything, every option, everywhere. But thats how we end with cramped user interfaces impossible to learn for a new, non computer savy user. UI/UX is difficult (especially for developpers) and we have to say "no" to adding things sometimes. This is suboptimal for the feature we want, but is for a greater good of the project in itself. So again, let's first think on how to make this feature look like, let's make mockups and when we decide it's better than the status quo we can implement :) |
#297 I put the link there For me the color pills are great but maybe not with the text, having a color associate with a type of documents make it really easy to spot what you're searching. I will try to make a version with the icon idea I had in the next days. |
@C4ptainCrunch what about this |
if we agree on that I will do some css for add a break on mobile |
I'm not a fan of this solution either, for multiple reasons:
What about trying a mockup with only text and see if it's legible ? |
Sorry I forgot to mention the icon I chose was just to show what it could look like, not definitive (they are modifiable from the admin). |
They are bit small but their color make them recognizable. We could maybe think to icon related to each filter to help the visualisation