Add predicate methods (#89) #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryTsepelev
requested changes
Jul 5, 2021
Co-authored-by: Dmitry Tsepelev <[email protected]>
|
Cool! Should I add a changelog entry and squash the commits? |
|
My suggestion was a bit different 🙂 |
Co-authored-by: Dmitry Tsepelev <[email protected]>
|
Ouch, now I see. Thanks! 🙂 |
DmitryTsepelev
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds predicate methods as suggested in #89.
It is loosely modeled after the implementation in rails.
I'm not 100% sure about the
method_missingbased implementation but at least that is how rails does it. Any thoughts?